Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Allow unsafeSsl for artemis connections #4081

Closed
wants to merge 1 commit into from
Closed

feat: Allow unsafeSsl for artemis connections #4081

wants to merge 1 commit into from

Conversation

NoUseFreak
Copy link

@NoUseFreak NoUseFreak commented Jan 9, 2023 •
edited
Loading

Add unsafeSsl option (like the prometheus scaler) to allow self-signed certificates.

Checklist

Fixes #

Relates to #

@NoUseFreak NoUseFreak requested a review from a team as a code owner January 9, 2023 10:42
semgrep-app[bot]
semgrep-app bot reviewed Jan 9, 2023
View reviewed changes
pkg/scalers/artemis_scaler.go Outdated Show resolved Hide resolved
JorTurFer
JorTurFer reviewed Jan 10, 2023
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, only 2 small nits inline

pkg/scalers/artemis_scaler.go Show resolved Hide resolved
pkg/scalers/artemis_scaler.go Outdated Show resolved Hide resolved
@JorTurFer
Copy link
Member

JorTurFer commented Jan 10, 2023 •
edited by github-actions bot
Loading

/run-e2e artemis*
Update: You can check the progress here

@NoUseFreak NoUseFreak mentioned this pull request Jan 16, 2023
Closed
1 task
zroubalik
zroubalik requested changes Jan 16, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@zroubalik
Copy link
Member

/run-e2e artemis*

zroubalik
zroubalik reviewed Jan 17, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test failures:

 === RUN   TestArtemisDefaultCorsHeader
--- FAIL: TestArtemisDefaultCorsHeader (0.00s)
panic: runtime error: invalid memory address or nil pointer dereference [recovered]
	panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x28 pc=0x1c90548]

CHANGELOG.md Outdated Show resolved Hide resolved
@NoUseFreak
feat(artemis scaler): Allow unsafeSsl (#4081)
f29ffcb 
Signed-off-by: Dries De Peuter <dries@stenic.io>
@JorTurFer
Copy link
Member

JorTurFer commented Feb 6, 2023 •
edited
Loading

Does unsafeSsl make sense once the customCA is merged? @kedacore/keda-core-contributors ?
I'm just sharing my thoughts, I don't have any opinion about this

@NoUseFreak
Copy link
Author

Closing as customCA can solve the issue

@NoUseFreak NoUseFreak closed this Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik requested changes

@semgrep-app semgrep-app[bot] semgrep-app[bot] left review comments

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NoUseFreak @JorTurFer @zroubalik