chore: Review CodeQL config #4133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JorTurFer
force-pushed
the
code-ql
branch
10 times, most recently
from
de97612 to
0915fe8
Compare
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
JorTurFer
added a commit
to JorTurFer/keda
that referenced
this pull request
Jan 18, 2023
JorTurFer
added a commit
to JorTurFer/keda
that referenced
this pull request
Jan 18, 2023
Fixes kedacore#4032 Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Jorge Turrado jorge_turrado@hotmail.es
I have split into 2 different workflows, the static analyzers because they need different triggers, in theory both can be executed with a regular
pull_requesttrigger but semgrep still has secrets (the token), so makes sense to have it safely, but CodeQL doesn't use secrets so moving it frompull_request_targettopull_requesthelps for future changes.I have added more rules to CodeQL, I'm not 100% sure if it will work or not, but I think so
Checklist
Fixes #4032