Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add Azure e2e tests #4200

Merged
merged 12 commits into from
Feb 9, 2023
Merged

chore: Add Azure e2e tests #4200

merged 12 commits into from
Feb 9, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Feb 5, 2023 •
edited
Loading

Checklist

  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #3891
Fixes #3895
Fixes #3889
Fixes #3890
Fixes #3892
Fixes #2928
Fixes #3887
Fixes #3888

Related to #3896

@JorTurFer
chore: Add Azure e2e tests
0b662f2 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 5, 2023 •
edited by github-actions bot
Loading

/run-e2e azure_application_insights*
Update: You can check the progress here

@JorTurFer
add blob tests
572d87b 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 5, 2023 •
edited by github-actions bot
Loading

/run-e2e azure_blob*
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Feb 5, 2023
Closed
@JorTurFer
add queue tests
bb7c89d 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 5, 2023 •
edited by github-actions bot
Loading

/run-e2e azure_queue*
Update: You can check the progress here

@JorTurFer
add data-explorer tests
cd4087a 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 5, 2023 •
edited by github-actions bot
Loading

/run-e2e azure_data_explorer*
Update: You can check the progress here

@JorTurFer JorTurFer mentioned this pull request Feb 5, 2023
Closed
@JorTurFer
add log analytics tests
827d63e 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
update changelog
3aad2b8 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 5, 2023 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@JorTurFer
fix typo in package names
ae00d6f 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 5, 2023 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@JorTurFer
remove unused var
395c5af 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
add azure monitor tests
8d3b860 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 5, 2023 •
edited by github-actions bot
Loading

/run-e2e azure_monitor*
Update: You can check the progress here

@JorTurFer JorTurFer changed the title WIP - chore: Add Azure e2e tests chore: Add Azure e2e tests Feb 5, 2023
@JorTurFer
fix styles
8dbca69 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 5, 2023 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@JorTurFer JorTurFer marked this pull request as ready for review February 5, 2023 21:57
@JorTurFer JorTurFer requested a review from a team as a code owner February 5, 2023 21:57
@JorTurFer
Copy link
Member Author

All azure scalers are covered (without and with both identity providers) as part of this PR except the Azure Event Hub because it's assigned to a contributor. I have asked him and if we cannot finish it or prefers that we do it, I'll add them in other PR (if we would have already merged this)

@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 6, 2023 •
edited by github-actions bot
Loading

/run-e2e azure_workload_identity_user_assigned*
Update: You can check the progress here

tomkerkhove
tomkerkhove reviewed Feb 6, 2023
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll leave this up to others to review but thanks!

tests/.env Show resolved Hide resolved
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 6, 2023 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@JorTurFer
add eventhub tests
99a7930 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 7, 2023 •
edited by github-actions bot
Loading

/run-e2e event_hub*
Update: You can check the progress here

@JorTurFer
fix style
e32dd65 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 7, 2023 •
edited by github-actions bot
Loading

/run-e2e azure*
Update: You can check the progress here

@zroubalik
Copy link
Member

@v-shenoy would you mind taking a look on these tests? I am by no means Azure expert 😄

zroubalik
zroubalik approved these changes Feb 8, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me, but I'd like to keep it open for Azure folks to take a look.

@v-shenoy
Copy link
Contributor

v-shenoy commented Feb 8, 2023

@v-shenoy would you mind taking a look on these tests? I am by no means Azure expert 😄

I'll take a look by EOD.

@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 8, 2023 •
edited
Loading

Except azure monitor (which there was pending), other scaler e2e tests are just copy&paste&update of the already existing tests.
Please review azure monitor e2e with calm and love because it's totally new

v-shenoy
v-shenoy approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@v-shenoy v-shenoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice work!

@JorTurFer
Copy link
Member Author

Looks good. Nice work!

Nice!
Thanks for the review :)

@JorTurFer JorTurFer merged commit 3082489 into kedacore:main Feb 9, 2023
@JorTurFer JorTurFer deleted the add-azure-e2e branch February 9, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove left review comments

@v-shenoy v-shenoy v-shenoy approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
4 participants
@JorTurFer @zroubalik @v-shenoy @tomkerkhove