Improve error logging by skipping logging of errors related to paused scalers

[aharonh]

A small addition to the Reconciliation loop to allow for skipping the reconciliation of the paused scaled objects. This addition is beneficial as without it, as it is now, many log messages are caused by a paused scaledobject whose scaler's running pre-conditions are not satisfied. For an example a database mysql scaler depends on may be down while the scaledobject is paused. There is no value in those logs so better to remove them to keep the logs useful, clean of noise, and efficient and easy to use.

Checklist

• When introducing a new scaler, I agree with the scaling governance policy
• I have verified that my change is according to the deprecations & breaking changes policy
• Tests have been added
• Changelog has been updated and is aligned with our changelog requirements
• A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• A PR is opened to update the documentation on (repo) (if applicable)
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #

[zroubalik]

Hi, did you actually test this change? I don't think it will help with your issue, because majority of the scaling logic is being driven by scaler handler: https://github.com/kedacore/keda/blob/main/pkg/scaling/scale_handler.go

I think that we should have a different approach.

[aharonh]

Hi, did you actually test this change? I don't think it will help with your issue, because majority of the scaling logic is being driven by scaler handler: https://github.com/kedacore/keda/blob/main/pkg/scaling/scale_handler.go

I think that we should have a different approach.

Hi @zroubalik ,

I just re-did the changes with the gpg signature that was missing. Yep, I tested it, looked like it works as expected:

• There were no errors when the ScaledObject was paused
• When unpaused, it worked as expected

Can you think of any further tests that would be useful to perform?

Thanks,
Aharon

[zroubalik]

Hi, did you actually test this change? I don't think it will help with your issue, because majority of the scaling logic is being driven by scaler handler: https://github.com/kedacore/keda/blob/main/pkg/scaling/scale_handler.go
I think that we should have a different approach.

Hi @zroubalik ,

I just re-did the changes with the gpg signature that was missing. Yep, I tested it, looked like it works as expected:

* There were no errors when the ScaledObject was paused

* When unpaused, it worked as expected

Can you think of any further tests that would be useful to perform?

Thanks, Aharon

Thanks!

Let's keep the conversation in the issue.

[zroubalik]

This PR fixes the problem, instead of skipping the loggin it stops the whole scaler. So closing this in favour of that PR.