Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fallback calculation returns correct value #4263

Merged
merged 5 commits into from
Feb 22, 2023
Merged

fix: Fallback calculation returns correct value #4263

merged 5 commits into from
Feb 22, 2023

Conversation

JorTurFer
Copy link
Member

Provide a description of what has been changed

Checklist

  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4249

@JorTurFer
fix: Fallback calculation returns correct value
8c18251 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer JorTurFer requested a review from a team as a code owner February 21, 2023 18:06
zroubalik
zroubalik requested changes Feb 21, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@JorTurFer
remove unrelated change
54750e4 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer JorTurFer enabled auto-merge (squash) February 21, 2023 18:37
@JorTurFer JorTurFer disabled auto-merge February 21, 2023 18:37
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 21, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) February 21, 2023 18:46
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 21, 2023 •
edited by github-actions bot
Loading

/run-e2e fallback*
Update: You can check the progress here

@JorTurFer
reduce stabilization window
6df6eba 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 22, 2023 •
edited by github-actions bot
Loading

/run-e2e fallback*
Update: You can check the progress here

@JorTurFer
set scaling value after restarting the server
5d48144 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 22, 2023 •
edited by github-actions bot
Loading

/run-e2e fallback*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 22, 2023 •
edited by github-actions bot
Loading

/run-e2e fallback*
Update: You can check the progress here

@JorTurFer JorTurFer disabled auto-merge February 22, 2023 09:48
@JorTurFer
set scaling value after restarting the server
093fb01 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 22, 2023 •
edited by github-actions bot
Loading

/run-e2e fallback*
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Feb 22, 2023 •
edited by github-actions bot
Loading

/run-e2e fallback*
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) February 22, 2023 10:57
@JorTurFer JorTurFer merged commit e6f019e into kedacore:main Feb 22, 2023
@JorTurFer JorTurFer deleted the fix-fallback-regression branch February 22, 2023 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Scaledobject fallback not working as expected when prometheus trigger is failing
2 participants
@JorTurFer @zroubalik