GitHub Runner passive scaler

[Eldarrin]

This is a new scaler that will use GitHub's REST API to schedule scaled runners. It is designed to work in conjunction with GitHub Actions.

Checklist

• When introducing a new scaler, I agree with the scaling governance policy
• I have verified that my change is according to the deprecations & breaking changes policy
• Tests have been added
• Changelog has been updated and is aligned with our changelog requirements
• A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• A PR is opened to update the documentation on (repo) (if applicable)
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #1732

[semgrep-app]

Semgrep found 6 questionable-assignment findings:

• pkg/scalers/github_runner_scaler.go: L435, L426, L411, L406, L401, L396

Should meta be modified when an error could be returned?

_{Created by questionable-assignment.}

[zroubalik]

@Eldarrin the unit test is really great and thorough, though do you think that we can add e2e test as well? It's one of our requirements for a new scaler.

[Eldarrin]

I'll look into the e2e next week :)

[zroubalik]

I'll look into the e2e next week :)

Thanks 🙏 just FYI, we plan to release 2.10 later this week (in case you would want to have that scaler in).

[zroubalik]

/run-e2e github*
Update: You can check the progress here

[zroubalik]

@Eldarrin could you please fix the Static Checks and please also make sure that you run go mod vendor and include changes in vendor dir in the PR :)

[JorTurFer]

I have added these envs @Eldarrin :

• GH_OWNER
• GH_REPOS
• GH_SCOPE
• GH_SO_WORKFLOW_ID
• GH_WORKFLOW_ID
• GH_AUTOMATIONS_PAT

[JorTurFer]

/run-e2e github*

[zroubalik]

/run-e2e github*
Update: You can check the progress here

[JorTurFer]

/run-e2e github*
Update: You can check the progress here

[JorTurFer]

@Eldarrin , how are you adding the deps to the vendor folder? I ask because there has been missing vendor deps twice and I'm afraid about if you add them manually. To update vendor folder, you just need to execute go mod vendor. Is this what you are doing?

[JorTurFer]

/run-e2e github*
Update: You can check the progress here

[Eldarrin]

@Eldarrin , how are you adding the deps to the vendor folder? I ask because there has been missing vendor deps twice and I'm afraid about if you add them manually. To update vendor folder, you just need to execute go mod vendor. Is this what you are doing?

They were in vendor; I just didn’t add them to my commit by mistake. In bed atm watching the builds and getting up when I see another oh damn moment. :)

[JorTurFer]

@Eldarrin , how are you adding the deps to the vendor folder? I ask because there has been missing vendor deps twice and I'm afraid about if you add them manually. To update vendor folder, you just need to execute go mod vendor. Is this what you are doing?

They were in vendor; I just didn’t add them to my commit by mistake. In bed atm watching the builds and getting up when I see another oh damn moment. :)

No worries, I just asked because it wasn't obvious to me the first time :)

[JorTurFer]

/run-e2e github*
Update: You can check the progress here

[JorTurFer]

LGTM! 2 small things, only inline and the other:
Could you add a test like https://github.com/kedacore/keda/blob/main/pkg/scalers/artemis_scaler_test.go#L145 to ensure the generated metric name?

[JorTurFer]

You have done an awesome work!
Thanks for this improvement ❤️

[JorTurFer]

/run-e2e github*
Update: You can check the progress here

[zroubalik]

LGTM

awesome job! Thanks for the contribution.