fix: stop scale loop for pause Scaledbject

[tobotg]

In the controller in the reconcile loop, when a scaledObject is paused (annotated with ), this fix stops the scaling logic (to prevent attempt to connect the to scalers), and deletes the generated HPA (so it is not querying KEDA Metric Server for metrics)

Checklist

• I have verified that my change is according to the deprecations & breaking changes policy
• Tests have been added
• Changelog has been updated and is aligned with our changelog requirements
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4253

[JorTurFer]

The new test is failing, could you take a look?

[tobotg]

@JorTurFer sure thing. I'll take a look.

[JorTurFer]

/run-e2e internals
Update: You can check the progress here

[tobotg]

@JorTurFer is there anything expected from me wrt the FOSS / build failures? Just checking.

[zroubalik]

@JorTurFer is there anything expected from me wrt the FOSS / build failures? Just checking.

no, ignore this for now

[zroubalik]

/run-e2e pause
Update: You can check the progress here

[zroubalik]

@tobotg seems like the e2e test is failing, could you please double check?

https://github.com/kedacore/keda/blob/main/tests/internals/pause_scaling/pause_scaling_test.go

[tobotg]

@tobotg seems like the e2e test is failing, could you please double check?

https://github.com/kedacore/keda/blob/main/tests/internals/pause_scaling/pause_scaling_test.go

sure thing. I'll have a look during the weekend.

[tobotg]

@zroubalik I tried to have a look, but can't find the detail of the test run that failed. Would you be able to help? Thanks

[JorTurFer]

You can see the execution log, clicking the link in the comment:

but in this case, the error is here: https://github.com/kedacore/keda/actions/runs/4819967110/jobs/8584143929#step:8:378
The scaling out test is failing

[tobotg]

@JorTurFer @zroubalik Thank you.
I looked and tested, and found that the tests fail consistently with a wait time of 1 min for WaitForDeploymentReplicaReadyCount, but succeed when I increase that wait time to 2 or 3 min. The behaviour seems fragile when the load (all the e2e tests launched) increases.
Would you agree to increase the wait time periods in the pause_scaling_test.go to fix this test?

[JorTurFer]

Would you agree to increase the wait time periods in the pause_scaling_test.go to fix this test?

Yes, go ahead.
Other tests have different timeouts, depending on the test internals. I guess that after the changes, the test needs more time to recover the scaling loop. 2-3 mins is something feasible

[JorTurFer]

Could you rebase main too? There are changes required for executing e2e tests

[tobotg]

@JorTurFer it should be fine now I guess. But this test is failing now. Do you mind triggering the e2e to check what when wrong? Thanks

[zroubalik]

/run-e2e
Update: You can check the progress here

[JorTurFer]

/run-e2e
Update: You can check the progress here

[zroubalik]

/run-e2e pause_scaling
Update: You can check the progress here

[zroubalik]

/run-e2e
Update: You can check the progress here

[zroubalik]

@tobotg could you please make sure that the PR contain only your commits?

[tobotg]

I ended up closing this and resubmitting a new PR.