Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e2e): uninstall KEDA properly #4491

Merged
merged 6 commits into from
May 2, 2023
Merged

fix(e2e): uninstall KEDA properly #4491

merged 6 commits into from
May 2, 2023

Conversation

JorTurFer
Copy link
Member

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

@JorTurFer JorTurFer requested a review from a team as a code owner May 1, 2023 11:22
@JorTurFer
fix(e2e): uninstall KEDA correctly
264c5c2 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented May 1, 2023 •
edited by github-actions bot
Loading

/run-e2e potato
Update: You can check the progress here

@JorTurFer
fix path filtering errors
864d7de 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
refactor the method to reduce the complexity
f860711 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
remove debug lines
db209a3 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
refactor run-all go to reduce the complexity
ad0a4ca 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented May 1, 2023 •
edited by github-actions bot
Loading

/run-e2e potato
Update: You can check the progress here

@JorTurFer
print the error reason after uninstall keda
0a28d2a 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented May 1, 2023 •
edited by github-actions bot
Loading

/run-e2e sequential
Update: You can check the progress here

@JorTurFer JorTurFer changed the title fix(e2e): uninstall KEDA correctly fix(e2e): uninstall KEDA properly May 1, 2023
@JorTurFer JorTurFer enabled auto-merge (squash) May 1, 2023 16:12
@tomkerkhove
Copy link
Member

/run-e2e potato Update: You can check the progress here

Your potato test failed, too bad

@JorTurFer JorTurFer merged commit 1c62684 into kedacore:main May 2, 2023
@JorTurFer JorTurFer deleted the fix-pr-comments branch May 2, 2023 06:11
@JorTurFer
Copy link
Member Author

JorTurFer commented May 2, 2023 •
edited
Loading

Your potato test failed, too bad

But it failed successfully 🤣
(Not keeping namespaces stuck)

JorTurFer added a commit to JorTurFer/keda that referenced this pull request May 2, 2023
@JorTurFer
fix(e2e): uninstall KEDA properly (kedacore#4491)
b674748
geoffrey1330 pushed a commit to geoffrey1330/keda that referenced this pull request Oct 4, 2023
@JorTurFer @geoffrey1330
fix(e2e): uninstall KEDA properly (kedacore#4491)
ad89eba 
Signed-off-by: geoffrey1330 <israelgeoffrey13@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JorTurFer @tomkerkhove