Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

find the stream leader the old way if nodes are not advertised #4525

Merged
merged 1 commit into from
May 9, 2023
Merged

find the stream leader the old way if nodes are not advertised #4525

merged 1 commit into from
May 9, 2023

Conversation

mfadhlika
Copy link
Contributor

Provide a description of what has been changed

Checklist

Fixes #4524

@mfadhlika mfadhlika requested a review from a team as a code owner May 4, 2023 03:29
@JorTurFer
Copy link
Member

JorTurFer commented May 7, 2023 •
edited by github-actions bot
Loading

/run-e2e jetstream_cluster
Update: You can check the progress here

@JorTurFer
Copy link
Member

Unit test are failing, could you check them?
https://github.com/kedacore/keda/actions/runs/4878814964/jobs/8704797046#step:12:707

@rayjanoka
Copy link
Contributor

thanks @mfadhlika! - I'll try to get some time to give this a test on my system.

@mfadhlika mfadhlika force-pushed the main branch 4 times, most recently from 84717e6 to 40a7914 Compare May 9, 2023 01:26
@mfadhlika
find the stream leader the old way if nodes are not advertised
60ccefd 
Signed-off-by: Muhammad Fadhlika <git@fadhlika.com>
@mfadhlika
Copy link
Contributor Author

@JorTurFer I have updated the test

@rayjanoka
Copy link
Contributor

nice1, tested good on my system. 🎉 🎉 🎉

@JorTurFer
Copy link
Member

JorTurFer commented May 9, 2023 •
edited by github-actions bot
Loading

/run-e2e jetstream_cluster
Update: You can check the progress here

JorTurFer
JorTurFer approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks for the improvement! ❤️

@JorTurFer JorTurFer enabled auto-merge (squash) May 9, 2023 06:43
@JorTurFer JorTurFer merged commit cf3cd1d into kedacore:main May 9, 2023
tobotg pushed a commit to tobotg/keda that referenced this pull request May 17, 2023
@mfadhlika @tobotg
find the stream leader the old way if nodes are not advertised (kedac…
efc8b83 
…ore#4525)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NATS JetStream scaler broke if nodes are not advertised
3 participants
@mfadhlika @JorTurFer @rayjanoka