Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Check if MaxReplicaCount is nil before access to it #4567

Merged
merged 1 commit into from
May 23, 2023
Merged

fix: Check if MaxReplicaCount is nil before access to it #4567

merged 1 commit into from
May 23, 2023

Conversation

zroubalik
Copy link
Member

@zroubalik zroubalik commented May 23, 2023 •
edited
Loading

Checklist

  • Tests have been added
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4568

@zroubalik zroubalik requested a review from a team as a code owner May 23, 2023 09:09
@zroubalik zroubalik mentioned this pull request May 23, 2023
Closed
1 task
@zroubalik zroubalik changed the title chore: add test ase for ScaledJob functions fix: Check if MaxReplicaCount is nil before access to it May 23, 2023
@zroubalik
Copy link
Member Author

zroubalik commented May 23, 2023 •
edited by github-actions bot
Loading

/run-e2e min_replica_sj
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) May 23, 2023 09:28
@zroubalik
Copy link
Member Author

zroubalik commented May 23, 2023 •
edited by github-actions bot
Loading

/run-e2e min_replica_sj
Update: You can check the progress here

@zroubalik
fix: Check if MaxReplicaCount is nil before access to it
a02f4db 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik zroubalik requested a review from JorTurFer May 23, 2023 13:13
@JorTurFer
Copy link
Member

JorTurFer commented May 23, 2023 •
edited by github-actions bot
Loading

/run-e2e min_replica_sj
Update: You can check the progress here

@zroubalik zroubalik merged commit 0a1f7a3 into kedacore:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ScaledJob: panic ifminReplicaCount is specified & maxReplicaCount is not set
2 participants
@zroubalik @JorTurFer