Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: explain how to execute e2e tests on PRs #4577

Merged
merged 4 commits into from
May 29, 2023

Conversation

JorTurFer
Copy link
Member

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer JorTurFer requested a review from a team as a code owner May 26, 2023 16:39
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, you might want to mention the label for skipping the execution

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

Nice, you might want to mention the label for skipping the execution

good idea

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@zroubalik zroubalik merged commit d917094 into kedacore:main May 29, 2023
@JorTurFer JorTurFer deleted the document-e2e branch May 29, 2023 13:53
prometherion pushed a commit to prometherion/keda that referenced this pull request May 31, 2023
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants