Job annotations

[InbarRose]

• Update scale_jobs.go
• Update CHANGELOG.md

add annotations from scaledjob spec to job spec
add new improvement to changelog

Relates to #4594

[JorTurFer]

looking good! Could you add a unit test to validate the annotations?
Please, update docs as well 🙏

[InbarRose]

looking good! Could you add a unit test to validate the annotations? Please, update docs as well pray

would be happy to add tests.
Can you help me understand where I should add them?

[JorTurFer]

Can you help me understand where I should add them?

You can use this test as example: https://github.com/kedacore/keda/blob/main/pkg/scaling/executor/scale_jobs_test.go#L202-L214
I'd add a test case calling to scaleExecutor.createJobs and checking the generated job

[InbarRose]

Can you help me understand where I should add them?

You can use this test as example: https://github.com/kedacore/keda/blob/main/pkg/scaling/executor/scale_jobs_test.go#L202-L214 I'd add a test case calling to scaleExecutor.createJobs and checking the generated job

those are all using mocks to simulate the scaling decision.
I am happy to add a new test to an existing framework, but I don't think this is the correct scope to generate a whole new test framework.
If there is already an existing test framework which will generate a new job from a scaled job, please share where i can find it.

[JorTurFer]

I am happy to add a new test to an existing framework, but I don't think this is the correct scope to generate a whole new test framework.

You don't need to generate the whole tests framework. There are other tests (I didn't link the correct one, sorry :( ) that mock the client to test only the executor: https://github.com/kedacore/keda/blob/main/pkg/scaling/executor/scale_jobs_test.go#L216-L287

You could do something similar, calling the client mock with an empty slice, implementing the Create function mock which just adds the new job to the slice, and checking the slice elements at the end of the call:

1. Implement the mock function for client.Create, storing the new created jobs in the slice that the mock receives during the creation
2. Add a test which starts the mock with an empty array and generate the scalerExecutor.
3. Call to scaleExecutor.createJobs with the needed info
4. After the end of the call, check the slice and evaluate if the job/jobs contain the annotations that you added in the ScaledJob

With this, you could check your code and you don't need to create the whole test framework, just adding the required mock functions is enough IMO

[zroubalik]

Agree with @JorTurFer, adding a test would be great.

[zroubalik]

@InbarRose any update on this please? We are about to do a new release.

[InbarRose]

I haven't had time to add the tests.
But i see someone added the doc changes already
kedacore/keda-docs#1145

[zroubalik]

Implemented in: #5106