Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support indexName in dynamodb scaler #4682

Merged
merged 5 commits into from
Jun 13, 2023

Conversation

Haegi
Copy link
Contributor

@Haegi Haegi commented Jun 12, 2023

Provide a description of what has been changed

Checklist

Fixes #4680

Relates to kedacore/keda-docs#1154

Haegi added 2 commits June 12, 2023 20:38
Signed-off-by: Haegi <benjamin.haegenlaeuer@everest-erp.com>
Signed-off-by: Haegi <benjamin.haegenlaeuer@everest-erp.com>
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

Signed-off-by: Haegi <benjamin.haegenlaeuer@everest-erp.com>
Signed-off-by: Haegi <benjamin.haegenlaeuer@everest-erp.com>
@Haegi Haegi marked this pull request as ready for review June 13, 2023 08:53
@Haegi Haegi requested a review from a team as a code owner June 13, 2023 08:53
@JorTurFer
Copy link
Member

Hi,
I have a question from my DynamoDB ignorance xD
Does adding the value to DynamoDB stream make sense?

@Haegi
Copy link
Contributor Author

Haegi commented Jun 13, 2023

Hi, I have a question from my DynamoDB ignorance xD Does adding the value to DynamoDB stream make sense?

Hi, I am not an DynamoDB streams expert but do they even offer something like a index value?
If yes, I am open to also contribute that in another PR.

@JorTurFer
Copy link
Member

I have no idea 😅, that's why I asked.
Let's continue only with this and if anyone wants the value in the other scaler, they can contribute too 😁

@JorTurFer
Copy link
Member

JorTurFer commented Jun 13, 2023

/run-e2e aws
Update: You can check the progress here

Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer JorTurFer enabled auto-merge (squash) June 13, 2023 22:03
@JorTurFer JorTurFer merged commit 739b770 into kedacore:main Jun 13, 2023
@JorTurFer
Copy link
Member

Thanks for the improvement! ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add indexName field to AWS DynamoDB scaler
2 participants