Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allow to change the Admission Webhooks port #4712

Merged
merged 2 commits into from
Jun 22, 2023

Conversation

mcantinqc
Copy link
Contributor

@mcantinqc mcantinqc commented Jun 20, 2023

Allow to use a custom port for the Admission Webhooks. That will be useful for project on EKS with a custom CNI.

Checklist

Fixes kedacore/charts#468

Relates to kedacore/charts#470

@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, please just fix the changelog

CHANGELOG.md Outdated Show resolved Hide resolved
@zroubalik
Copy link
Member

@mcantinqc could you please fix the conflict in changelog?

Signed-off-by: Mathieu Cantin <103442330+mcantinqc@users.noreply.github.com>
Signed-off-by: Mathieu Cantin <103442330+mcantinqc@users.noreply.github.com>
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik
Copy link
Member

zroubalik commented Jun 21, 2023

/run-e2e scaled_object_validation
Update: You can check the progress here

@zroubalik zroubalik merged commit 013b720 into kedacore:main Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to set hostnetwork on Webhook
2 participants