-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Allow to change the Admission Webhooks port #4712
Conversation
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, please just fix the changelog
@mcantinqc could you please fix the conflict in changelog? |
Signed-off-by: Mathieu Cantin <103442330+mcantinqc@users.noreply.github.com>
Signed-off-by: Mathieu Cantin <103442330+mcantinqc@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/run-e2e scaled_object_validation |
Allow to use a custom port for the Admission Webhooks. That will be useful for project on EKS with a custom CNI.
Checklist
Fixes kedacore/charts#468
Relates to kedacore/charts#470