Improve events of CRDs #4829

SpiritZhou · 2023-07-28T08:12:15Z

Adding more events about keda CRD

Checklist

I have verified that my change is according to the deprecations & breaking changes policy
Tests have been added
Changelog has been updated and is aligned with our changelog requirements
Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #3764

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

github-actions · 2023-07-28T08:12:27Z

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

Add an entry in our changelog in alphabetical order and link related issue
Update the documentation, if needed
Add unit & e2e tests for your changes
GitHub checks are passing
Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

Our contribution guide

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

JorTurFer

Nice improvement! I have left some comments inline 😄
Could we add coverage to these events within e2e tests?

CHANGELOG.md

controllers/keda/clustertriggerauthentication_controller.go

controllers/keda/scaledjob_controller.go

controllers/keda/scaledobject_controller.go

controllers/keda/triggerauthentication_controller.go

JorTurFer

Nice improvement! I have left some comments inline 😄
Could we add coverage to these events within e2e tests?

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

…hou/keda into spiritzhou/improveevents

controllers/keda/scaledobject_controller.go

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

JorTurFer

Looking good! Nice job 💪
Could you add an e2e test for these events?

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

SpiritZhou · 2023-08-17T09:24:00Z

Looking good! Nice job 💪 Could you add an e2e test for these events?

I can't find a way to trigger some events such as SetStatusConditions or ParseGVKR. Do you have an idea to trigger these events?

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

JorTurFer

LGTM! ❤️

JorTurFer · 2023-08-24T16:45:32Z

/run-e2e internal
Update: You can check the progress here

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

JorTurFer · 2023-08-25T07:24:22Z

/run-e2e internal
Update: You can check the progress here

JorTurFer · 2023-08-25T07:24:49Z

Please ignore this:

misclick 🤦

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

tomkerkhove · 2023-08-25T13:28:24Z

/run-e2e internal
Update: You can check the progress here

* Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update CHANGELOG.md Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update CHANGELOG.md Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> --------- Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: Yoon Park <yoongon.park@gmail.com>

* Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update CHANGELOG.md Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update CHANGELOG.md Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> --------- Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>

* Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update CHANGELOG.md Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> * Update CHANGELOG.md Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> --------- Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com> Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: anton.lysina <alysina@gmail.com>

SpiritZhou added 4 commits July 28, 2023 11:43

Update

19549eb

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Update

3c10eba

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Update

a33c626

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Update

b3b7c96

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

SpiritZhou requested a review from a team as a code owner July 28, 2023 08:12

Merge branch 'main' into spiritzhou/improveevents

979b6ac

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

JorTurFer reviewed Jul 31, 2023

View reviewed changes

SpiritZhou and others added 3 commits August 1, 2023 10:02

Update CHANGELOG.md

e395c8c

Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es> Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Update

a6a47ca

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Merge branch 'spiritzhou/improveevents' of https://github.com/SpiritZ…

5fb2b9d

…hou/keda into spiritzhou/improveevents

tomkerkhove reviewed Aug 10, 2023

View reviewed changes

controllers/keda/scaledobject_controller.go Outdated Show resolved Hide resolved

Update

46f4b59

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

JorTurFer reviewed Aug 15, 2023

View reviewed changes

Update

4923829

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

SpiritZhou added 2 commits August 17, 2023 17:34

Update

ac20a01

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Update

454af07

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

SpiritZhou requested review from JorTurFer and tomkerkhove August 24, 2023 07:26

JorTurFer approved these changes Aug 24, 2023

View reviewed changes

SpiritZhou added 2 commits August 25, 2023 15:12

Update

5fc93cb

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

Merge branch 'main' into spiritzhou/improveevents

92c65aa

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

JorTurFer closed this Aug 25, 2023

JorTurFer reopened this Aug 25, 2023

Update CHANGELOG.md

1054ebd

Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>

tomkerkhove enabled auto-merge (squash) August 25, 2023 13:28

tomkerkhove disabled auto-merge August 25, 2023 13:28

tomkerkhove enabled auto-merge (squash) August 25, 2023 13:29

tomkerkhove merged commit 20abf20 into kedacore:main Aug 25, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve events of CRDs #4829

Improve events of CRDs #4829

SpiritZhou commented Jul 28, 2023 •

edited by tomkerkhove

Loading

github-actions bot commented Jul 28, 2023

JorTurFer left a comment

JorTurFer left a comment

JorTurFer left a comment

SpiritZhou commented Aug 17, 2023

JorTurFer left a comment

JorTurFer commented Aug 24, 2023 •

edited by github-actions bot

Loading

JorTurFer commented Aug 25, 2023 •

edited by github-actions bot

Loading

JorTurFer commented Aug 25, 2023

tomkerkhove commented Aug 25, 2023 •

edited by github-actions bot

Loading

Improve events of CRDs #4829

Improve events of CRDs #4829

Conversation

SpiritZhou commented Jul 28, 2023 • edited by tomkerkhove Loading

Checklist

github-actions bot commented Jul 28, 2023

JorTurFer left a comment

Choose a reason for hiding this comment

JorTurFer left a comment

Choose a reason for hiding this comment

JorTurFer left a comment

Choose a reason for hiding this comment

SpiritZhou commented Aug 17, 2023

JorTurFer left a comment

Choose a reason for hiding this comment

JorTurFer commented Aug 24, 2023 • edited by github-actions bot Loading

JorTurFer commented Aug 25, 2023 • edited by github-actions bot Loading

JorTurFer commented Aug 25, 2023

tomkerkhove commented Aug 25, 2023 • edited by github-actions bot Loading

SpiritZhou commented Jul 28, 2023 •

edited by tomkerkhove

Loading

JorTurFer commented Aug 24, 2023 •

edited by github-actions bot

Loading

JorTurFer commented Aug 25, 2023 •

edited by github-actions bot

Loading

tomkerkhove commented Aug 25, 2023 •

edited by github-actions bot

Loading