Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add testing documentation #4884

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Conversation

JorTurFer
Copy link
Member

I have ported the documentation that we provided during graduation DD to the repository in order to make it publicly accessible and easy to find

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4173

@JorTurFer JorTurFer requested a review from a team as a code owner August 16, 2023 16:05
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

🏖️ Over the summer, the response time will be longer than usual due to maintainers taking time off so please bear with us.

While you are waiting, make sure to:

Learn more about:

@JorTurFer JorTurFer changed the title chore: Add testing strategy document chore: Add testing strategy documentation Aug 16, 2023
JorTurFer and others added 3 commits August 16, 2023 21:13
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@SpiritZhou
Copy link
Contributor

Just want to share something when writing e2e tests. When I try to run my new e2e tests locally, the setup command ("go test -v -tags e2e ./utils/setup_test.go") deployed the official KEDA image, which is not convenient for debugging new tests with a changed KEDA. I suggest adding a parameter in the setup command for deploying the custom image repository so that developers can use their KEDA repository for debugging.

@JorTurFer
Copy link
Member Author

Just want to share something when writing e2e tests. When I try to run my new e2e tests locally, the setup command ("go test -v -tags e2e ./utils/setup_test.go") deployed the official KEDA image, which is not convenient for debugging new tests with a changed KEDA. I suggest adding a parameter in the setup command for deploying the custom image repository so that developers can use their KEDA repository for debugging.

It's already supported but not properly documented I think. As KEDA is deployed using make, and Makefile uses variables, you can set those envs (globally o for the command) and that's all.
Let me update the PR with that info

@JorTurFer JorTurFer changed the title chore: Add testing strategy documentation chore: Add testing documentation Aug 17, 2023
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Copy link
Member Author

@SpiritZhou @zroubalik PTAL

@SpiritZhou
Copy link
Contributor

@SpiritZhou @zroubalik PTAL

It looks great now!

@JorTurFer JorTurFer enabled auto-merge (squash) August 18, 2023 06:55
@JorTurFer
Copy link
Member Author

/skip-e2e

@JorTurFer JorTurFer merged commit e694286 into kedacore:main Aug 18, 2023
20 checks passed
@JorTurFer JorTurFer deleted the add-testing branch August 18, 2023 06:55
@JorTurFer
Copy link
Member Author

lol, although I requested a revision of @zroubalik , looks like GH already took into account the previous approval and the automerger did its job. I guess that I had to dismiss the approval instead or request another review :/
image

yoongon pushed a commit to yoongon/keda that referenced this pull request Aug 26, 2023
* Add testing strategy document

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* Update TESTING.md

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* Update TESTING.md

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* add extra info to tests

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

---------

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Yoon Park <yoongon.park@gmail.com>
Adarsh-verma-14 pushed a commit to Adarsh-verma-14/keda that referenced this pull request Sep 4, 2023
* Add testing strategy document

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* Update TESTING.md

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* Update TESTING.md

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* add extra info to tests

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

---------

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
* Add testing strategy document

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* Update TESTING.md

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* Update TESTING.md

Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>

* add extra info to tests

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>

---------

Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide documentation on our testing strategy
5 participants