-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show only logs with a severity level of ERROR or higher in the stderr #4952
Conversation
Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com>
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
Think this looks good but I'm no go expert so will leave it to @zroubalik @JorTurFer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the improvement :)
Just one small nit (the static checks are failing due to it)
Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com>
Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com>
/run-e2e internal |
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
…kedacore#4952) * Show only logs with a severity level of ERROR or higher in the stderr Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com> * modify the CHANGELOG.md Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com> * update message in changelog Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com> * Update CHANGELOG.md Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> --------- Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: anton.lysina <alysina@gmail.com>
Did this PR really fixed #4049? |
Signed-off-by: Adarsh-verma-14 t_adarsh.verma@india.nec.com
In the logs of keda-metrics-apiserver, show only printing errors, but errors should go to stderr.
Checklist
Fixes #4049