Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show only logs with a severity level of ERROR or higher in the stderr #4952

Merged
merged 4 commits into from
Sep 13, 2023

Conversation

Adarsh-verma-14
Copy link
Contributor

Signed-off-by: Adarsh-verma-14 t_adarsh.verma@india.nec.com

In the logs of keda-metrics-apiserver, show only printing errors, but errors should go to stderr.

Checklist

  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #4049

Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com>
@Adarsh-verma-14 Adarsh-verma-14 requested a review from a team as a code owner September 6, 2023 18:15
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@tomkerkhove
Copy link
Member

Think this looks good but I'm no go expert so will leave it to @zroubalik @JorTurFer

Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the improvement :)
Just one small nit (the static checks are failing due to it)

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com>
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com>
@zroubalik
Copy link
Member

zroubalik commented Sep 12, 2023

/run-e2e internal
Update: You can check the progress here

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik zroubalik merged commit 5b7a66e into kedacore:main Sep 13, 2023
16 of 18 checks passed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
…kedacore#4952)

* Show only logs with a severity level of ERROR or higher in the stderr

Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com>

* modify the CHANGELOG.md

Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com>

* update message in changelog

Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com>

* Update CHANGELOG.md

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>

---------

Signed-off-by: Adarsh-verma-14 <t_adarsh.verma@india.nec.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

metrics-apiserver json logs
4 participants