Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add validations for Stabilizationwindowseconds #4983

Merged
merged 6 commits into from
Sep 20, 2023
Merged

Add validations for Stabilizationwindowseconds #4983

merged 6 commits into from
Sep 20, 2023

Conversation

Indresh2410
Copy link
Contributor

@Indresh2410 Indresh2410 commented Sep 18, 2023 •
edited
Loading

Provide a description of what has been changed

Checklist

Fixes #4976

Relates to #

@Indresh2410
Add Minimum and Maximum limit for StabilizationWindowSeconds
b822817 
Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>
@Indresh2410
Remove unwanted package
485df25 
Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>
@Indresh2410 Indresh2410 requested a review from a team as a code owner September 18, 2023 18:25
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@Indresh2410 Indresh2410 changed the title Stabilizationwindowseconds fix Add validations for Stabilizationwindowseconds Sep 18, 2023
@Indresh2410
Modify changelog
6b4f4ca 
Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>
@Indresh2410
Address Review Comments
53f09fe 
Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>
@Indresh2410
Address Review Comments
57a1862 
Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>
@Indresh2410
Trim Whitespace
65298e2 
Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>
@JorTurFer
Copy link
Member

JorTurFer commented Sep 19, 2023 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

zroubalik
zroubalik approved these changes Sep 20, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution @Indresh2410!

@zroubalik zroubalik merged commit d131480 into kedacore:main Sep 20, 2023
19 checks passed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@Indresh2410 @toniiiik
Add validations for Stabilizationwindowseconds (kedacore#4983)
1cafb6f 
Signed-off-by: Indresh2410 <indreshprakash24@gmail.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
@vzdai vzdai mentioned this pull request Aug 13, 2024
Open
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@Indresh2410 @JorTurFer @zroubalik