Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add activationTarget for formulas #4998

Merged
merged 26 commits into from
Sep 26, 2023
Merged

feat: Add activationTarget for formulas #4998

merged 26 commits into from
Sep 26, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Sep 25, 2023 •
edited
Loading

Checklist

  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to kedacore/keda-docs#1230

@JorTurFer JorTurFer requested a review from a team as a code owner September 25, 2023 15:16
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@JorTurFer JorTurFer changed the title feat: Add activationTarget for formulas and parallel querying feat: Add activationTarget for formulas Sep 25, 2023
JorTurFer and others added 14 commits September 25, 2023 19:41
@JorTurFer
feat: query metrics in parallel
ab3b30d 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
add scaledjobs
79f00a3 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
add logic inside operator
e6bddbb 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
add activation test
a136fda 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
remove the requirement of value using the scaler AsMetricSource
75acb47 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
add missing change
d59ac67 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
reduce complexity
6950082 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
revert go.uber.org/automaxprocs
40be21c 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
revert scaledjobs split
8cee73c 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
update changelog
2409f46 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
update e2e test
0c621d3 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
fix styles
5c0a995 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
fix styles
5627851 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
fix test issues
09e2fd9 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Copy link
Member Author

JorTurFer commented Sep 25, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
apply feedback
ff7c44f 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
update AsSource detection
796e739 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Copy link
Member Author

JorTurFer commented Sep 25, 2023 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@gauron99
Copy link
Contributor

gauron99 commented Sep 25, 2023 •
edited
Loading

LGTM (if the test passes :D)

@JorTurFer
fix scaling test
ac8e3d1 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
fix error from last refactor
cae15e6 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Copy link
Member Author

JorTurFer commented Sep 25, 2023 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@JorTurFer
Copy link
Member Author

JorTurFer commented Sep 25, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
increase wait on test
bdaf87d 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
increase timeout on test
ae8b141 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Copy link
Member Author

JorTurFer commented Sep 26, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

zroubalik
zroubalik reviewed Sep 26, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, just a minor nits

pkg/scaling/scale_handler.go Outdated Show resolved Hide resolved
pkg/scaling/scale_handler.go Outdated Show resolved Hide resolved
pkg/scaling/scale_handler.go Outdated Show resolved Hide resolved
@JorTurFer
refactor the code and add commets
443de34 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
remove whiteline
7e4a743 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
Copy link
Member Author

JorTurFer commented Sep 26, 2023 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

zroubalik
zroubalik reviewed Sep 26, 2023
View reviewed changes
pkg/scaling/scale_handler.go Outdated Show resolved Hide resolved
pkg/scaling/scale_handler.go Outdated Show resolved Hide resolved
pkg/scaling/scale_handler.go Outdated Show resolved Hide resolved
pkg/scaling/scale_handler.go Show resolved Hide resolved
@JorTurFer
remove the request
07ae3ee 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
remove the request
aad8352 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
remove the request
b047b4f 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@JorTurFer
fix typo
dd6d790 
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
@zroubalik
Copy link
Member

zroubalik commented Sep 26, 2023 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

zroubalik
zroubalik approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik zroubalik merged commit d593951 into kedacore:main Sep 26, 2023
18 checks passed
@JorTurFer JorTurFer deleted the add-parallelism branch September 26, 2023 15:24
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@JorTurFer @toniiiik
feat: Add activationTarget for formulas (kedacore#4998)
44ddd22 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
Signed-off-by: Jorge Turrado <jorge.turrado@scrm.lidl>
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gauron99 gauron99 gauron99 approved these changes

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JorTurFer @gauron99 @zroubalik