Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configurable K8s cluster domain for Cert Manager #5012

Merged
merged 1 commit into from
Sep 28, 2023
Merged

feat: configurable K8s cluster domain for Cert Manager #5012

merged 1 commit into from
Sep 28, 2023

Conversation

zroubalik
Copy link
Member

@zroubalik zroubalik commented Sep 27, 2023 •
edited
Loading

Default is cluster.local, users have a possibility to overwrite via parameter --k8s-cluster-domain on KEDA operator

Checklist

Fixes #4861

@zroubalik zroubalik requested a review from a team as a code owner September 27, 2023 20:44
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@zroubalik
Copy link
Member Author

zroubalik commented Sep 27, 2023 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) September 27, 2023 21:05
@zroubalik
Copy link
Member Author

zroubalik commented Sep 28, 2023 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@tomkerkhove
Copy link
Member

tomkerkhove commented Sep 28, 2023 •
edited by JorTurFer
Loading

/run-e2e internal
Update: You can check the progress here

@JorTurFer : I cancel this because there is another commit fixing an error

@zroubalik
feat: configurable K8s cluster domain for Cert Manager
f2cc48a 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik
Copy link
Member Author

zroubalik commented Sep 28, 2023 •
edited by github-actions bot
Loading

/run-e2e internal
Update: You can check the progress here

@zroubalik zroubalik merged commit 345c372 into kedacore:main Sep 28, 2023
18 checks passed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@zroubalik @toniiiik
feat: configurable K8s cluster domain for Cert Manager (kedacore#5012)
a457813 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JorTurFer JorTurFer JorTurFer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Custom cluster domain support for other values than cluster.local
3 participants
@zroubalik @tomkerkhove @JorTurFer