Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pkg linting issues #5022

Merged
merged 4 commits into from
Oct 1, 2023
Merged

Pkg linting issues #5022

merged 4 commits into from
Oct 1, 2023

Conversation

teivah
Copy link
Contributor

@teivah teivah commented Oct 1, 2023

Fixing several small linting issues in /pkg:

  • Public comments
  • Inconsistent slice declaration
  • Useless parenthesis
  • Useless type conversion

Checklist

Fixes #

Relates to #

@teivah teivah requested a review from a team as a code owner October 1, 2023 13:07
@github-actions
Copy link

github-actions bot commented Oct 1, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

Signed-off-by: Teiva Harsanyi <teiva.harsanyi@gmail.com>
Signed-off-by: Teiva Harsanyi <teiva.harsanyi@gmail.com>
Signed-off-by: Teiva Harsanyi <teiva.harsanyi@gmail.com>
Signed-off-by: Teiva Harsanyi <teiva.harsanyi@gmail.com>
@teivah teivah marked this pull request as ready for review October 1, 2023 14:02
@zroubalik
Copy link
Member

zroubalik commented Oct 1, 2023

/run-e2e internal
Update: You can check the progress here

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@zroubalik zroubalik enabled auto-merge (squash) October 1, 2023 14:56
@zroubalik zroubalik merged commit 4e42c3f into kedacore:main Oct 1, 2023
19 checks passed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
Signed-off-by: Teiva Harsanyi <teiva.harsanyi@gmail.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants