Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup deprecation for v2.13 release #5038

Merged

Conversation

dttung2905
Copy link
Contributor

@dttung2905 dttung2905 commented Oct 2, 2023

Provide a description of what has been changed
Hi team,

I create this PR to clean up the deprecation for v2.13

Checklist

Fixes #5051

@dttung2905 dttung2905 requested a review from a team as a code owner October 2, 2023 10:11
@github-actions
Copy link

github-actions bot commented Oct 2, 2023

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@JorTurFer
Copy link
Member

@zroubalik @tomkerkhove , can we remove these things? I'd like to prevent last release doubts before merging.
These are the deprecations:

Both modifies trigger spec, so in theory we are modifying the CRD and we aren't allowed as we discussed last time. Despite of that, I'd go ahead with at least the removal of the secret from trigger.metadata because it has security implications

@zroubalik
Copy link
Member

@zroubalik @tomkerkhove , can we remove these things? I'd like to prevent last release doubts before merging. These are the deprecations:

* [Deprecate `tlsCertFile` in external scaler in favour of mor fine-grained config #4549](https://github.com/kedacore/keda/issues/4549)

* [Remove Azure Data Explorer 'metadata.clientSecret' #4514](https://github.com/kedacore/keda/issues/4514)

Both modifies trigger spec, so in theory we are modifying the CRD and we aren't allowed as we discussed last time. Despite of that, I'd go ahead with at least the removal of the secret from trigger.metadata because it has security implications

I agree.

@dttung2905 dttung2905 force-pushed the cleanup-deprecation-for-2-13-release branch 2 times, most recently from b146cc5 to 2dae13c Compare October 4, 2023 16:39
@dttung2905 dttung2905 force-pushed the cleanup-deprecation-for-2-13-release branch from 64b57a5 to c4e4c89 Compare November 22, 2023 08:51
CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
@dttung2905 dttung2905 force-pushed the cleanup-deprecation-for-2-13-release branch from 3fb694b to 8c2ecd0 Compare November 27, 2023 21:34
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Thanks! 🙇

@JorTurFer
Copy link
Member

JorTurFer commented Dec 6, 2023

/run-e2e azure
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) December 6, 2023 19:37
@JorTurFer JorTurFer merged commit 9f89985 into kedacore:main Dec 6, 2023
19 checks passed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecation cleanup for 2.13 release
4 participants