-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup deprecation for v2.13 release #5038
Cleanup deprecation for v2.13 release #5038
Conversation
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
@zroubalik @tomkerkhove , can we remove these things? I'd like to prevent last release doubts before merging.
Both modifies trigger spec, so in theory we are modifying the CRD and we aren't allowed as we discussed last time. Despite of that, I'd go ahead with at least the removal of the secret from trigger.metadata because it has security implications |
I agree. |
b146cc5
to
2dae13c
Compare
64b57a5
to
c4e4c89
Compare
Signed-off-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: Dao Thanh Tung <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
Signed-off-by: dttung2905 <ttdao.2015@accountancy.smu.edu.sg>
3fb694b
to
8c2ecd0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks! 🙇
/run-e2e azure |
Signed-off-by: anton.lysina <alysina@gmail.com>
Provide a description of what has been changed
Hi team,
I create this PR to clean up the deprecation for v2.13
Checklist
Fixes #5051