Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevented stuck status due to timeouts during scalers generation #5084

Merged
merged 8 commits into from
Oct 16, 2023
Merged

fix: Prevented stuck status due to timeouts during scalers generation #5084

merged 8 commits into from
Oct 16, 2023

Conversation

JorTurFer
Copy link
Member

@JorTurFer JorTurFer commented Oct 15, 2023 •
edited
Loading

Checklist

  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5083

@JorTurFer
fix: Prevented stuck status due to timeouts during scalers generation
a927de3 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer JorTurFer requested a review from a team as a code owner October 15, 2023 14:45
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@JorTurFer
fix style
584b8f0 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Add e2e test case
452b910 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Oct 15, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer
execute the scaler close in a goroutine
7d2b612 
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Oct 15, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here
Update: You can check the progress here

zroubalik
zroubalik reviewed Oct 16, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, I think this should help!

pkg/scaling/scale_handler.go Outdated Show resolved Hide resolved
tests/sequential/broken_scaledobject_tolerancy/broken_scaledobject_tolerancy_test.go Show resolved Hide resolved
@JorTurFer
Update pkg/scaling/scale_handler.go
841c704 
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer
Update pkg/scaling/scale_handler.go
a9343f2 
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer
Update tests/sequential/broken_scaledobject_tolerancy/broken_scaledob…
8a1d474 
…ject_tolerancy_test.go

Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member Author

JorTurFer commented Oct 16, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) October 16, 2023 10:49
@JorTurFer
Update tests/sequential/broken_scaledobject_tolerancy/broken_scaledob…
81dd743 
…ject_tolerancy_test.go

Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
zroubalik
zroubalik approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JorTurFer
Copy link
Member Author

JorTurFer commented Oct 16, 2023 •
edited by github-actions bot
Loading

/run-e2e
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) October 16, 2023 14:04
@JorTurFer JorTurFer merged commit 5706fb3 into kedacore:main Oct 16, 2023
19 checks passed
@JorTurFer JorTurFer deleted the fix-stuck branch October 16, 2023 17:01
@zroubalik zroubalik mentioned this pull request Nov 27, 2023
Closed
16 tasks
zroubalik pushed a commit to zroubalik/keda that referenced this pull request Nov 27, 2023
@JorTurFer @zroubalik
fix: Prevented stuck status due to timeouts during scalers generation (…
27bf91e 
…kedacore#5084)
zroubalik pushed a commit to zroubalik/keda that referenced this pull request Nov 27, 2023
@JorTurFer @zroubalik
fix: Prevented stuck status due to timeouts during scalers generation (…
aa0fb0b 
…kedacore#5084)

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
zroubalik pushed a commit to zroubalik/keda that referenced this pull request Nov 27, 2023
@JorTurFer @zroubalik
fix: Prevented stuck status due to timeouts during scalers generation (…
d017ab5 
…kedacore#5084)

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
zroubalik pushed a commit that referenced this pull request Nov 27, 2023
@JorTurFer @zroubalik
fix: Prevented stuck status due to timeouts during scalers generation (…
a9566fd 
…#5084)

Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@JorTurFer @toniiiik
fix: Prevented stuck status due to timeouts during scalers generation (…
4dcdd30 
…kedacore#5084)

Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

KEDA operator works slowly (or doesn't work) when some ScaledObject reconciliation produces timeouts
2 participants
@JorTurFer @zroubalik