Support profiling for keda components

[yuvalweber]

Provide a description of what has been changed

Checklist

• When introducing a new scaler, I agree with the scaling governance policy
• I have verified that my change is according to the deprecations & breaking changes policy
• Tests have been added
• Changelog has been updated and is aligned with our changelog requirements
• A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
• A PR is opened to update the documentation on (repo) (if applicable)
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #

Relates to #4789

[github-actions]

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

• Add an entry in our changelog in alphabetical order and link related issue
• Update the documentation, if needed
• Add unit & e2e tests for your changes
• GitHub checks are passing
• Is the DCO check failing? Here is how you can fix DCO issues

Learn more about:

• Our contribution guide

[zroubalik]

/run-e2e internal
Update: You can check the progress here

[yuvalweber]

Hey @zroubalik can you please inform me what is missing in all of the PRs I opened (kedacore/charts#549, kedacore/keda-docs#1250, #5091 ) in order to merge everything?

[tomkerkhove]

Hey @zroubalik can you please inform me what is missing in all of the PRs I opened (kedacore/charts#549, kedacore/keda-docs#1250, #5091 ) in order to merge everything?

@yuvalweber The e2e tests are failing, can you please check?

/run-e2e internal Update: You can check the progress here

[yuvalweber]

Hey @tomkerkhove can you help me a bit?
I looked at the errors and I see things failing because it's trying to create resources on namespaces that being terminated or something with rate limit, can you please help me figure out if it's related to my change (cause it shouldn't)?

[yuvalweber]

Hey @tomkerkhove would love for also update on this

[zroubalik]

/run-e2e internal
Update: You can check the progress here

[zroubalik]

Hey @tomkerkhove can you help me a bit? I looked at the errors and I see things failing because it's trying to create resources on namespaces that being terminated or something with rate limit, can you please help me figure out if it's related to my change (cause it shouldn't)?

Env problem, the re-run passed 🚀

[yuvalweber]

Hey @zroubalik do I need to write test?
Sorry i'm just not familiar with writing tests in golang and not sure if necessary in this situation

[zroubalik]

Hey @zroubalik do I need to write test? Sorry i'm just not familiar with writing tests in golang and not sure if necessary in this situation

@yuvalweber I don't think tests are needed for this kind of feature. On the other hand a short blogpost on how you used this profiler would be awesome 😃

[yuvalweber]

Would love to do it 😄 .
Can you share example of blogpost so I could see the format and know how to copy it?
I could share the example related to the issue I had before #4687

[zroubalik]

Would love to do it 😄 . Can you share example of blogpost so I could see the format and know how to copy it? I could share the example related to the issue I had before #4687

DM me on slack :)

[yuvalweber]

Hey @zroubalik need you to rerun the e2e tests.
I wanted to merge PR and rebase but accidentally just updated by branch which triggered this new requirement for this test

[yuvalweber]

Hey @zroubalik can you just help me understand why it won't let me merge this?

[zroubalik]

Hey @zroubalik can you just help me understand why it won't let me merge this?

Only maitiainers can merge a PR, we usually do that once all PRs (feature/charts/docs) are ready.

[yuvalweber]

Alright so when @tomkerkhove will finish reviewing my changes I'll be happy to merge.
Meanwhile I'll work on the blogpost

[zroubalik]

Alright so when @tomkerkhove will finish reviewing my changes I'll be happy to merge. Meanwhile I'll work on the blogpost

You don't have to do anything on the PRs (only additional fixes requested by reviews). We will handle the rest

[yuvalweber]

Alright so when @tomkerkhove will finish reviewing my changes I'll be happy to merge. Meanwhile I'll work on the blogpost

You don't have to do anything on the PRs (only additional fixes requested by reviews). We will handle the rest

I think I addressed to all of the requests you guys reviewed but if I missed something please let me know 😄