Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the implementation of OpenTelemetry integration #5116

Merged
merged 9 commits into from
Nov 1, 2023
Merged

Improve the implementation of OpenTelemetry integration #5116

merged 9 commits into from
Nov 1, 2023

Conversation

SpiritZhou
Copy link
Contributor

@SpiritZhou SpiritZhou commented Oct 23, 2023 •
edited
Loading

Improve the implementation of OpenTelemetry integration to reduce the callback register times

Checklist

Relates to (#5101)

@SpiritZhou
Update
3c745e4 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update changelog
70f90dc 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou SpiritZhou requested a review from a team as a code owner October 23, 2023 08:05
@github-actions
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@SpiritZhou
Update
6bc4efb 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Merge branch 'main' into spiritzhou/imporveopentelemetry
6b3174e
tomkerkhove
tomkerkhove reviewed Oct 23, 2023
View reviewed changes
Copy link
Member

@tomkerkhove tomkerkhove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add some tests for this change please?

CHANGELOG.md Outdated Show resolved Hide resolved
@SpiritZhou
Update
eab5dc1 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
tomkerkhove
tomkerkhove reviewed Oct 24, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@SpiritZhou @tomkerkhove
Update CHANGELOG.md
bfb7573 
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou
Update
1be4b7f 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@SpiritZhou SpiritZhou requested a review from JorTurFer October 26, 2023 06:34
@JorTurFer
Copy link
Member

JorTurFer commented Oct 29, 2023 •
edited by github-actions bot
Loading

/run-e2e sequential
Update: You can check the progress here

@SpiritZhou
Merge branch 'main' into spiritzhou/imporveopentelemetry
53cd373 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
@zroubalik
Merge branch 'main' into spiritzhou/imporveopentelemetry
258c09f 
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
@zroubalik zroubalik merged commit faf8c9a into kedacore:main Nov 1, 2023
16 of 17 checks passed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
@SpiritZhou @tomkerkhove
@zroubalik @toniiiik
Improve the implementation of OpenTelemetry integration (kedacore#5116)
5c0baa0 
Signed-off-by: SpiritZhou <iammrzhouzhenghan@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Tom Kerkhove <kerkhove.tom@gmail.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomkerkhove tomkerkhove tomkerkhove left review comments

@zroubalik zroubalik zroubalik approved these changes

@JorTurFer JorTurFer Awaiting requested review from JorTurFer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SpiritZhou @JorTurFer @zroubalik @tomkerkhove