-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
General: Bubble up AuthRef TriggerAuthentication errors as ScaledObject events #5219
Merged
zroubalik
merged 12 commits into
kedacore:main
from
BojanZelic:bubble-up-authref-errors
Dec 21, 2023
Merged
General: Bubble up AuthRef TriggerAuthentication errors as ScaledObject events #5219
zroubalik
merged 12 commits into
kedacore:main
from
BojanZelic:bubble-up-authref-errors
Dec 21, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
…ct events Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
…ct events Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
Thank you for your contribution! 🙏 We will review your PR as soon as possible. While you are waiting, make sure to:
Learn more about: |
…ct events Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
/run-e2e |
For the E2E failures; they look unrelated to me
|
zroubalik
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ct events Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
…c/keda into bubble-up-authref-errors
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
/run-e2e |
toniiiik
pushed a commit
to toniiiik/keda
that referenced
this pull request
Jan 15, 2024
…ct events (kedacore#5219) Signed-off-by: Bojan Zelic <bnzelic@gmail.com> Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com> Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com> Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bubble up triggerauth errors for things like hashicorp vault / azure keyvault config/connectivity issues whenever there are problems;
example mis-configuring vault with a bad role will now create an k8s event on the scaledObject:
example mis-configuring the vault url
Checklist
Fixes #5190