Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General: Bubble up AuthRef TriggerAuthentication errors as ScaledObject events #5219

Merged
merged 12 commits into from
Dec 21, 2023

Conversation

BojanZelic
Copy link
Contributor

@BojanZelic BojanZelic commented Nov 27, 2023

Bubble up triggerauth errors for things like hashicorp vault / azure keyvault config/connectivity issues whenever there are problems;

example mis-configuring vault with a bad role will now create an k8s event on the scaledObject:

Warning  KEDAScalerFailed         38s (x17 over 6m6s)    keda-operator  Error making API request.\n\nURL: PUT https://my-vault-server/v1/auth/cluster/login\nCode: 403. Errors:\n\n* permission denied

example mis-configuring the vault url

Warning  KEDAScalerFailed         30s (x13 over 51s)  keda-operator  Get "bad-vault-url/v1/auth/token/lookup-self": unsupported protocol scheme "" 

Checklist

  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5190

Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
…ct events

Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
…ct events

Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
@BojanZelic BojanZelic requested a review from a team as a code owner November 27, 2023 23:07
Copy link

Thank you for your contribution! 🙏 We will review your PR as soon as possible.

While you are waiting, make sure to:

Learn more about:

@zroubalik
Copy link
Member

zroubalik commented Dec 7, 2023

/run-e2e
Update: You can check the progress here

@BojanZelic
Copy link
Contributor Author

BojanZelic commented Dec 7, 2023

For the E2E failures; they look unrelated to me

  1. gcp_storage_workload_identity_test.go - seems this test can't be run in parallel?
/__w/keda/keda/tests/scalers/gcp/gcp_storage_workload_identity/gcp_storage_workload_identity_test.go:***76
2023-12-07T18:20:03.3063023Z         	Error:      	Received unexpected error:
2023-12-07T18:20:03.3063980Z         	            	Creating gs://gcp-storage-workload-identity-test-bucket/...
2023-12-07T18:20:03.3066748Z         	            	ServiceException: 409 A Cloud Storage bucket named 'gcp-storage-workload-identity-test-bucket' already exists. Try another name. Bucket names must be globally unique across all Google Cloud projects, including those outside of your organization.
2023-12-07T18:20:03.3067530Z         	            	command terminated with exit code ***
2023-12-07T18:20:03.3068071Z         	Test:       	TestScaler
2023-12-07T18:20:03.3069390Z         	Messages:   	Failed to create GCS bucket - Creating gs://gcp-storage-workload-identity-test-bucket/...
2023-12-07T18:20:03.3072153Z         	            	ServiceException: 409 A Cloud Storage bucket named 'gcp-storage-workload-identity-test-bucket' already exists. Try another name. Bucket names must be globally unique across all Google Cloud projects, including those outside of your organization.
  1. azure_pipelines_adv_test seems like it's connectivity issues to Azure? & doesn't use TriggerAuthentication object
2023-12-07T18:20:08.6082758Z ***0***3-***-07T***7:50:30Z	ERROR	azure_pipelines_scaler	error getting pipelines queue length	***"type": "ScaledJob", "namespace": "azure-pipelines-demands-test-ns" , "name": "golang-alldemand-sj", "error": "Get \"***/_apis/distributedtask/pools/***3/jobrequests?$top=***50\": context canceled"***

Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zroubalik
Copy link
Member

zroubalik commented Dec 21, 2023

/run-e2e
Update: You can check the progress here

@zroubalik zroubalik enabled auto-merge (squash) December 21, 2023 14:23
@zroubalik zroubalik disabled auto-merge December 21, 2023 16:34
@zroubalik zroubalik enabled auto-merge (squash) December 21, 2023 16:34
@zroubalik zroubalik disabled auto-merge December 21, 2023 16:34
@zroubalik zroubalik merged commit 956ddd1 into kedacore:main Dec 21, 2023
18 of 19 checks passed
toniiiik pushed a commit to toniiiik/keda that referenced this pull request Jan 15, 2024
…ct events (kedacore#5219)

Signed-off-by: Bojan Zelic <bnzelic@gmail.com>
Signed-off-by: Zbynek Roubalik <zroubalik@gmail.com>
Co-authored-by: Zbynek Roubalik <zroubalik@gmail.com>
Signed-off-by: anton.lysina <alysina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bubble Up vault errors to ScaledObject Events
2 participants