Fix custom keda deployment documentation #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed the helm install command in contriubtion part on the README.md and the CREATE-NEW-SCALer.md files (the actual commands was not working)
|
|
tomkerkhove
reviewed
Jan 16, 2020
tomkerkhove
approved these changes
Jan 16, 2020
|
I also updated the create new scaler documentation, where the steps was outdated. Btw i'm wondering if is safe to replace the text saying: [tag used in step *] with: $IMAGE_TAG, since it is exported as an environment variable, so it can be used directly in the commands, it will become something like that:
|
tomkerkhove
approved these changes
Jan 16, 2020
|
hey @tomkerkhove @inuyasha82 is the create new scaler documentation linked from somewhere ? |
|
However, we might want to check how it relates to https://github.com/kedacore/keda#deploying-custom-keda |
preflightsiren
pushed a commit
to preflightsiren/keda
that referenced
this pull request
Nov 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in issue #531 the documentation about deployin custom keda is not actually working, this PR should contain the correct command to instruct helm on using the custom build instead of the stable one.