Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MongoDB Scaler - Scheme field support #5566

Merged
merged 4 commits into from
Mar 12, 2024

Conversation

tico88612
Copy link
Contributor

@tico88612 tico88612 commented Mar 1, 2024

I added a scheme field to support the SRV record in this PR.

If it is not set, the default value is mongodb.

Checklist

(https://github.com/kedacore/governance/blob/main/DEPRECATIONS.md)

  • Tests have been added
  • Changelog has been updated and is aligned with our changelog requirements
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5544

Relates to keda-docs #1326

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
@tico88612 tico88612 requested a review from a team as a code owner March 1, 2024 15:59
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the feaature!

@JorTurFer
Copy link
Member

JorTurFer commented Mar 1, 2024

/run-e2e mongo
Update: You can check the progress here

Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@JorTurFer
Copy link
Member

JorTurFer commented Mar 12, 2024

/run-e2e mongo
Update: You can check the progress here

@JorTurFer JorTurFer enabled auto-merge (squash) March 12, 2024 22:32
@JorTurFer JorTurFer merged commit 42a1de4 into kedacore:main Mar 12, 2024
19 checks passed
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Mar 15, 2024
* feat: add schema field in mongodb scaler

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>

* test: mongodb scaler support srv scheme

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>

* docs: Changelog about MongoDB Scaler scheme field

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>

---------

Signed-off-by: tico88612 <17496418+tico88612@users.noreply.github.com>
Signed-off-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
Co-authored-by: Jorge Turrado Ferrero <Jorge_turrado@hotmail.es>
@tico88612 tico88612 deleted the feat/mongodb-add-scheme branch April 11, 2024 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MongoDB Scaler - MongoDB Atlas connection string support
2 participants