-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove deprecated AAD-Pod-Identity and AWS-KIAM auths #5782
Conversation
Signed-off-by: Jorge Turrado <jorge_turrado@hotmail.es>
/run-e2e |
/run-e2e azure |
Hey @JorTurFer ! |
What do you mean? v2.14 still has support for it: https://github.com/kedacore/keda/blob/release/v2.14/pkg/scalers/azure/azure_aad_podidentity.go We have just removed it from the main branch, but it means that next version won't have it. Are you using ´main´ tag? |
I've spent some time on researching and figure it out. We have Keda installed in another namespace than we're watching into, so the resolution was to add that namespace to watchNamespace parameter. Sorry for bothering you! We're also migration to Workload Identity and the error triggered me to think that it might be related to the change. |
Both auth were deprecated and we have to remove it for v2.15.
I know there are still some references to ActiveDirectoyEndpoint which aren't directly required either because we won't support aad-pod-identity anymore. They will be removed as part of this other PR that supports new SDKs and the merge conflicts will already be terrible without removing more fields than the strictly required on this PR
Checklist
Fixes #5035
Fixes #5085