Refactor arangodb scaler config

[dttung2905]

Refactor arango scaler config reading with a better way

Checklist

• When introducing a new scaler, I agree with the scaling governance policy
• I have verified that my change is according to the deprecations & breaking changes policy
• Tests have been added
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

Relates to #5797

[wozniakjan]

nice, looking rather good! :)

[dttung2905]

/run-e2e arangodb
Update: You can check the progress here

[wozniakjan]

lgtm, well done! :)

I noticed few nits, to make the review easier, I submitted them as a PR to your PR - ptal dttung2905#1

[wozniakjan]

ptal @kedacore/keda-contributors, I think this is good to merge

[zroubalik]

/run-e2e arangodb
Update: You can check the progress here

[dttung2905]

/run-e2e arangodb
Update: You can check the progress here

[dttung2905]

Not too sure why this e2e fails all of the sudden though https://github.com/kedacore/keda/actions/runs/9253331273/job/25452795586

0s
Run MESSAGE="$COMMENT_BODY"
  MESSAGE="$COMMENT_BODY"
  REGEX='/run-e2e (.+)'
  if [[ "$MESSAGE" =~ $REGEX ]]
  then
    export E2E_TEST_REGEX="$(echo ${BASH_REMATCH[[1](https://github.com/kedacore/keda/actions/runs/9253331273/job/25452795586#step:7:1)]} | head -1)"
  fi
  make e[2](https://github.com/kedacore/keda/actions/runs/9253331273/job/25452795586#step:7:2)e-regex-check
  shell: sh -e {0}
  env:
    E2E_CHECK_NAME: e2e tests
    COMMENT_BODY: /run-e2e arangodb
make: *** No rule to make target 'e2e-regex-check'.  Stop.
Error: Process completed with exit code 2.

The E2E_TEST_REGEX return arangodb from my local when I replace $COMMENT_BODY with /run-e2e arangodb which is expected 🤔
@JorTurFer Do you have any idea about this ? I can see the same thing is happening on other PR as well https://github.com/kedacore/keda/actions/runs/9259917601

[wozniakjan]

looks like #5783 introduced validation on the regex passed to the e2e tests, which seems to be misbehaving now, I'm checking this

[wozniakjan]

@dttung2905 there appears to be a combination of two things

• fix: e2e test regex check tag #5831 - bad tag argument passed in the makefile
• after that merges, can you please rebase your PR on the latest main? The workflow code executes from main but it runs actions/checkout to get the content of the PR. While the workflow already has make e2e-regex-check, this branch doesn't yet have that in the Makefile hence the failure

make: *** No rule to make target 'e2e-regex-check'.  Stop.

[dttung2905]

/run-e2e arangodb
Update: You can check the progress here

[dttung2905]

ptal @kedacore/keda-contributors. Please help to merge when you have time 🙏