-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow CA dirs to be specified beyond /custom/ca/ #5859
Conversation
@joelsmith could you please create an issue to track this feature and link it in the changelog & docs/helm PRs then? Thanks |
f676473
to
73bf0b3
Compare
Hi @zroubalik, I have created the issue and the docs & chart PRs. I think they are ready for a review. |
/run-e2e internal |
BTW, because of the added loop and resulting indent increase, the patch is easier to read with |
/run-e2e internal |
@zroubalik Thanks for re-running the test -- it passed this time. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I would like @JorTurFer to check this one as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only small comment inline
Signed-off-by: Joel Smith <joelsmith@redhat.com>
/run-e2e internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Nice improvement ❤️
Signed-off-by: Joel Smith <joelsmith@redhat.com> Signed-off-by: uucloud <uucloud@qq.com>
Add
--ca-dir
flag to KEDA operator to specify directories with CA certificates for scalers to authenticate TLS connections (defaults to /custom/ca)Checklist
Fixes #5860
See kedacore/charts#650
See kedacore/keda-docs#1402