Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: GCP Pub/Sub scaler add configurable fallback value when no metric value found #5897

Merged

Conversation

Caislear
Copy link
Contributor

@Caislear Caislear commented Jun 19, 2024

Added an optional valueIfNull configuration value to the GCP Pub/Sub as also found in the older GCP Stackdriver scaler. This allows for a default fallback value when GCP returns no value for a given metric. This prevents excessive error logging especially when using multiple pubsub scalers with low subscription traffic.

Checklist

Relates to #
#5896

Documentation update

@Caislear Caislear force-pushed the gcp-pubsub-add-is-null-default-value branch from b7f6dcf to 19237c2 Compare June 19, 2024 09:05
@Caislear Caislear changed the title GCP Pub/Sub Scaler: add configurable fallback value when no metric value found feat: GCP Pub/Sub scaler add configurable fallback value when no metric value found Jun 19, 2024
@Caislear Caislear marked this pull request as ready for review June 19, 2024 09:29
@Caislear Caislear requested a review from a team as a code owner June 19, 2024 09:29
@Caislear Caislear force-pushed the gcp-pubsub-add-is-null-default-value branch from 19237c2 to 78765cc Compare June 19, 2024 12:48
@zroubalik
Copy link
Member

zroubalik commented Jun 25, 2024

/run-e2e gcp
Update: You can check the progress here

@Caislear Caislear force-pushed the gcp-pubsub-add-is-null-default-value branch from 78765cc to 6b43b92 Compare July 1, 2024 15:23
@Caislear
Copy link
Contributor Author

Caislear commented Jul 8, 2024

/run-e2e gcp Update: You can check the progress here

@zroubalik anything else needed from my side to get this pr merged in ?

Signed-off-by: Benjamin Woodley <bwoodley012@gmail.com>
@Caislear Caislear force-pushed the gcp-pubsub-add-is-null-default-value branch from 6b43b92 to aecfdfb Compare July 15, 2024 15:32
Copy link
Member

@JorTurFer JorTurFer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the improvement 😄

@JorTurFer
Copy link
Member

JorTurFer commented Jul 22, 2024

/run-e2e gcp
Update: You can check the progress here

@JorTurFer JorTurFer merged commit 4a14698 into kedacore:main Jul 25, 2024
19 checks passed
@JorTurFer
Copy link
Member

Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants