Add azure-workload auth to MSSQL scaler

[rickbrouwer]

• Refactor the scaler to match the new metadata guidelines.
• Added azure-workload auth

Checklist

• I have verified that my change is according to the deprecations & breaking changes policy
• Tests have been added
• Changelog has been updated and is aligned with our changelog requirements
• A PR is opened to update the documentation on (repo) (if applicable)
• Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #6104
Relates to #5797

[rickbrouwer]

Hi @tomkerkhove

I was refactoring the MSSQL scaler to match the new metadata guidelines. I thought I would also nice to add the requested Azure workload feature. I do not work with Azure myself and I mainly have to rely on reading about it. The unittest is successful, but I would like to see this very well checked. Could you check this PR? If I'm completely off track I could also leave it at just refactoring.

[tomkerkhove]

Thanks a ton!

Sadly, I don't do code contributions here so maybe @kedacore/keda-contributors can help with review

[rickbrouwer]

Hi @pauldotyu!

I saw that you did a lot of work for the Azure workload identity, for example with the RabbitMQ. I was refactoring the MSSQL scaler to match the new metadata guidelines. I thought I would also nice to add the #6104 Azure workload feature. I do not work with Azure myself and I mainly have to rely on reading about it. The unittest is successful, but I would like to see this very well checked.

Is this something you can look into? If I'm completely off track, please let me know.

[tomkerkhove]

Let's not poke random people and wait for the group that I have mentioned please =)

[tomkerkhove]

Also, if the PR is ready for review - Please publish it. Draft PRs are typically WIP PRs

[rickbrouwer]

Let's not poke random people and wait for the group that I have mentioned please =)

my sincere apologies

[tomkerkhove]

No worries

[tomkerkhove]

/run-e2e *
Update: You can check the progress here

[JorTurFer]

I think that we could cover this with e2e test as we have an Azure subscription. Could you open a PR to the testing infra repo to spin up and configure the database?

[rickbrouwer]

I think that we could cover this with e2e test as we have an Azure subscription. Could you open a PR to the testing infra repo to spin up and configure the database?

Is a feature request in https://github.com/kedacore/testing-infrastructure ok?

[JorTurFer]

Is a feature request in kedacore/testing-infrastructure ok?

yes 😄

[zroubalik]

@rickbrouwer @JorTurFer any update on this please?

[JorTurFer]

The testing infrastructure has to be deployed but @rickbrouwer needs help with that and I've not had time yet