Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some incorrect parameter parsing in Gitlab Runner #6173

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dovics
Copy link

@dovics dovics commented Sep 18, 2024

Provide a description of what has been changed

  1. Fix null pointer when runnerScopeFromEnv or ownerFromEnv environment variable is empty
  2. Expose parsing errors when applicationID or installationID isn't int, and refine error reporting

Checklist

Fixes #6156 #6159

Relates to #

Signed-off-by: wangrushen <wrs369@88.com>
@dovics dovics requested a review from a team as a code owner September 18, 2024 09:03
@dovics dovics changed the title fix: panic when owner or runnerScope env is empty Fix some incorrect parameter parsing in Gitlab Runner Sep 20, 2024
Signed-off-by: wangrushen <wrs369@88.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant