Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce PR #5974: Remove klogr dependency and move to zap #6578

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

aliaqel-stripe
Copy link
Contributor

@aliaqel-stripe aliaqel-stripe commented Feb 28, 2025

Reintroducing #5794

This PR reintroduces the above PR to refactor metrics-server to use zap instead of klogr. This not only removes the deprecated dependency but it also enables for JSON logging, a frequently requested feature in the metrics server.

I also updated the dev container protoc version so that it does not overwrite the protoc version used to generate proto.

Additionally, I have

Checklist

  • I have verified that my change is according to the deprecations & breaking changes policy
  • Changelog has been updated and is aligned with our changelog requirements
  • A PR is opened to update our Helm chart (repo) (if applicable, ie. when deployment manifests are modified)
  • A PR is opened to update the documentation on (repo) (if applicable)
  • Commits are signed with Developer Certificate of Origin (DCO - learn more)

Fixes #5732 , #4049

Relates to #741, #1543

Copy link

semgrep-app bot commented Feb 28, 2025

Semgrep found 1 no-sudo-in-dockerfile finding:

Avoid using sudo in Dockerfiles. Running processes as a non-root user can help reduce the potential impact of configuration errors and security vulnerabilities.

Signed-off-by: Ali Aqel <aliaqel@stripe.com>
Signed-off-by: Ali Aqel <aliaqel@stripe.com>
@aliaqel-stripe aliaqel-stripe marked this pull request as ready for review February 28, 2025 22:42
@aliaqel-stripe aliaqel-stripe requested a review from a team as a code owner February 28, 2025 22:42
@aliaqel-stripe
Copy link
Contributor Author

this change appears to have introduced a memory leak, will diagnose and then reach out to review

Signed-off-by: Ali Aqel <aliaqel@stripe.com>
Signed-off-by: Ali Aqel <aliaqel@stripe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metrics Server: klogr.New is deprecated use textlogger.NewLogger instead
1 participant