-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v2] autoscaling v2beta1 -> v2beta2 and minor refactoring #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
zroubalik
changed the title
autoscaling v2beta1 -> v2beta2 and minor refactoring
[v2] autoscaling v2beta1 -> v2beta2 and minor refactoring
Apr 8, 2020
ahmelsayed
approved these changes
Apr 8, 2020
zroubalik
added a commit
to zroubalik/keda
that referenced
this pull request
Apr 14, 2020
* scaledObjectFinalizer minor refactor Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * autoscaling v2beta1 -> v2beta2 Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * apiregistration.k8s.io v1beta1 -> v1 Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
zroubalik
added a commit
that referenced
this pull request
Apr 16, 2020
* scaledObjectFinalizer minor refactor Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * autoscaling v2beta1 -> v2beta2 Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * apiregistration.k8s.io v1beta1 -> v1 Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
zroubalik
added a commit
to zroubalik/keda
that referenced
this pull request
Apr 27, 2020
* scaledObjectFinalizer minor refactor Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * autoscaling v2beta1 -> v2beta2 Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * apiregistration.k8s.io v1beta1 -> v1 Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
AmithGanesh
pushed a commit
to AmithGanesh/keda
that referenced
this pull request
May 18, 2020
* scaledObjectFinalizer minor refactor Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * autoscaling v2beta1 -> v2beta2 Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * apiregistration.k8s.io v1beta1 -> v1 Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> Signed-off-by: Amith Ganesh <amith.ganesh1284@gmail.com>
zroubalik
added a commit
to zroubalik/keda
that referenced
this pull request
May 20, 2020
* scaledObjectFinalizer minor refactor Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * autoscaling v2beta1 -> v2beta2 Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * apiregistration.k8s.io v1beta1 -> v1 Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
zroubalik
added a commit
to zroubalik/keda
that referenced
this pull request
Jun 17, 2020
* scaledObjectFinalizer minor refactor Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * autoscaling v2beta1 -> v2beta2 Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * apiregistration.k8s.io v1beta1 -> v1 Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
zroubalik
added a commit
to zroubalik/keda
that referenced
this pull request
Jul 7, 2020
* scaledObjectFinalizer minor refactor Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * autoscaling v2beta1 -> v2beta2 Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * apiregistration.k8s.io v1beta1 -> v1 Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
zroubalik
added a commit
that referenced
this pull request
Aug 6, 2020
* scaledObjectFinalizer minor refactor Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * autoscaling v2beta1 -> v2beta2 Signed-off-by: Zbynek Roubalik <zroubali@redhat.com> * apiregistration.k8s.io v1beta1 -> v1 Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
SpiritZhou
pushed a commit
to SpiritZhou/keda
that referenced
this pull request
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2beta1
tov2beta2
, in fact it is an API change, shouldn't affect functionality.v1
(v1beta1
was used previously and could be potentionaly deprecated soon,v1
is supported on kubernetes >= v1.11, so no problems on this side wrt compatibility).Fixes #721