Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] autoscaling v2beta1 -> v2beta2 and minor refactoring #734

Merged
merged 3 commits into from
Apr 8, 2020

Conversation

zroubalik
Copy link
Member

@zroubalik zroubalik commented Apr 8, 2020

  • changing autoscaling version from v2beta1 to v2beta2, in fact it is an API change, shouldn't affect functionality.
  • minor refactoring of finalizer on ScaledObject
  • updating apiregistration/APIService used by Metrics server to v1 (v1beta1 was used previously and could be potentionaly deprecated soon, v1 is supported on kubernetes >= v1.11, so no problems on this side wrt compatibility).

Fixes #721

Zbynek Roubalik added 3 commits April 8, 2020 20:00
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik zroubalik changed the title autoscaling v2beta1 -> v2beta2 and minor refactoring [v2] autoscaling v2beta1 -> v2beta2 and minor refactoring Apr 8, 2020
@ahmelsayed ahmelsayed merged commit a2c7bff into kedacore:v2 Apr 8, 2020
zroubalik added a commit to zroubalik/keda that referenced this pull request Apr 14, 2020
* scaledObjectFinalizer minor refactor

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* autoscaling v2beta1 -> v2beta2

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* apiregistration.k8s.io v1beta1 -> v1

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
zroubalik added a commit that referenced this pull request Apr 16, 2020
* scaledObjectFinalizer minor refactor

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* autoscaling v2beta1 -> v2beta2

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* apiregistration.k8s.io v1beta1 -> v1

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
zroubalik added a commit to zroubalik/keda that referenced this pull request Apr 27, 2020
* scaledObjectFinalizer minor refactor

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* autoscaling v2beta1 -> v2beta2

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* apiregistration.k8s.io v1beta1 -> v1

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
AmithGanesh pushed a commit to AmithGanesh/keda that referenced this pull request May 18, 2020
* scaledObjectFinalizer minor refactor

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* autoscaling v2beta1 -> v2beta2

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* apiregistration.k8s.io v1beta1 -> v1

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Amith Ganesh <amith.ganesh1284@gmail.com>
zroubalik added a commit to zroubalik/keda that referenced this pull request May 20, 2020
* scaledObjectFinalizer minor refactor

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* autoscaling v2beta1 -> v2beta2

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* apiregistration.k8s.io v1beta1 -> v1

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
zroubalik added a commit to zroubalik/keda that referenced this pull request Jun 17, 2020
* scaledObjectFinalizer minor refactor

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* autoscaling v2beta1 -> v2beta2

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* apiregistration.k8s.io v1beta1 -> v1

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
zroubalik added a commit to zroubalik/keda that referenced this pull request Jul 7, 2020
* scaledObjectFinalizer minor refactor

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* autoscaling v2beta1 -> v2beta2

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* apiregistration.k8s.io v1beta1 -> v1

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
zroubalik added a commit that referenced this pull request Aug 6, 2020
* scaledObjectFinalizer minor refactor

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* autoscaling v2beta1 -> v2beta2

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>

* apiregistration.k8s.io v1beta1 -> v1

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik zroubalik deleted the v2-1 branch August 11, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants