Adding label for metrics service selection #745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The metrics service that is being created by the Operator SDK uses a the name label of the Operator https://github.com/operator-framework/operator-sdk/blob/f50d3f0f8e7d269e583116a666a354f5d931d8a1/pkg/metrics/metrics.go#L112. Since this label is not currently being added to the pod the service does not have any matching endpoints so metrics would not be able to be scraped from the service. Signed-off-by: tbickford <travisrbickford@gmail.com>
zroubalik
approved these changes
Apr 15, 2020
SpiritZhou
pushed a commit
to SpiritZhou/keda
that referenced
this pull request
Jul 18, 2023
Signed-off-by: Aleksander Slominski <aslom@us.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The metrics service that is being created by the Operator SDK uses a the name label of the Operator https://github.com/operator-framework/operator-sdk/blob/f50d3f0f8e7d269e583116a666a354f5d931d8a1/pkg/metrics/metrics.go#L112. Since this label is not currently being added to the pod the service does not have any matching endpoints so metrics would not be able to be scraped from the service.