Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] Update PR build action for v2 #751

Merged
merged 1 commit into from
Apr 17, 2020
Merged

[v2] Update PR build action for v2 #751

merged 1 commit into from
Apr 17, 2020

Conversation

ahmelsayed
Copy link
Contributor

Signed-off-by: Ahmed ElSayed ahmed@elsayed.io

This change sets the image used for PR validation to kedacore/build-tools:v2, which is built from the build-tools.Dockerfile in the v2 branch

Signed-off-by: Ahmed ElSayed <ahmed@elsayed.io>
@ahmelsayed ahmelsayed changed the title Update PR build action for v2 [v2] Update PR build action for v2 Apr 16, 2020
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@zroubalik zroubalik merged commit d12caec into v2 Apr 17, 2020
@zroubalik zroubalik deleted the ahmels/v2-pr-action branch April 17, 2020 08:10
zroubalik pushed a commit to zroubalik/keda that referenced this pull request Apr 27, 2020
Signed-off-by: Ahmed ElSayed <ahmed@elsayed.io>
zroubalik pushed a commit to zroubalik/keda that referenced this pull request May 20, 2020
Signed-off-by: Ahmed ElSayed <ahmed@elsayed.io>
zroubalik pushed a commit to zroubalik/keda that referenced this pull request Jun 17, 2020
Signed-off-by: Ahmed ElSayed <ahmed@elsayed.io>
zroubalik pushed a commit to zroubalik/keda that referenced this pull request Jul 7, 2020
Signed-off-by: Ahmed ElSayed <ahmed@elsayed.io>
zroubalik pushed a commit that referenced this pull request Aug 6, 2020
Signed-off-by: Ahmed ElSayed <ahmed@elsayed.io>
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants