[v2] use patch to update Status.LastActiveTime #755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
ahmelsayed
approved these changes
Apr 21, 2020
zroubalik
added a commit
to zroubalik/keda
that referenced
this pull request
Apr 27, 2020
zroubalik
added a commit
to zroubalik/keda
that referenced
this pull request
May 20, 2020
zroubalik
added a commit
to zroubalik/keda
that referenced
this pull request
Jun 17, 2020
zroubalik
added a commit
to zroubalik/keda
that referenced
this pull request
Jul 7, 2020
zroubalik
added a commit
that referenced
this pull request
Aug 6, 2020
SpiritZhou
pushed a commit
to SpiritZhou/keda
that referenced
this pull request
Jul 18, 2023
…#755) * Added alternative expression field in AWS CloudWatch scaler Signed-off-by: Dekel Barzilay <dekelev@gmail.com> * Added alternative expression field in AWS CloudWatch scaler Signed-off-by: Dekel Barzilay <dekelev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zbynek Roubalik zroubali@redhat.com
if we use
client.Status().Patch()instead ofclient.Status().Update()we shouldn't hit the issue with modifying old resource anymore. Pach is merging only those fields that were updated. I have tested it and it seems like it is working correctly. We can revert back to the loop mechanism if there are going to be any issues.