Introduce shortnames for our CRDs #775
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Kerkhove <kerkhove.tom@gmail.com>
|
Happy to document, but I'm not sure what these would look like - Just drop a note in there or are we good on that front? |
|
Great idea, but these CRDs are generated from the code, there are special markers to do so, https://github.com/kedacore/keda/blob/master/pkg/apis/keda/v1alpha1/scaledobject_types.go#L20-L26 So we need to add those markers in the code and regenerate the CRDs. I can do that. |
|
Ha, I'm a moron. Happy to give this a try if you can give me a pointer to some docs! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tom Kerkhove kerkhove.tom@gmail.com
Provide a description of what has been changed
Checklist
Tests have been addedFixes #774