Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v2] triggerauth CRD: show configured parameters #795

Merged
merged 1 commit into from
Apr 29, 2020

Conversation

zroubalik
Copy link
Member

Signed-off-by: Zbynek Roubalik zroubali@redhat.com

kubect get ta prints these columns:

NAME     PODIDENTITY   SECRET   ENV
taname   azure                  

Fixes #778

Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
@zroubalik zroubalik requested a review from tomkerkhove April 29, 2020 11:40
@zroubalik zroubalik requested a review from ahmelsayed as a code owner April 29, 2020 11:40
@tomkerkhove
Copy link
Member

This is a stretch but i presume we can't add info on where it's used?

@zroubalik
Copy link
Member Author

It is not possible with current implementation. It would require some logic in the operator, to watch ScaledObjects/ScaledJobs and TriggerAuths and then map triggerauth usages and store them probably into triggerauth.Status. Then we will be able to print them here.

@tomkerkhove
Copy link
Member

It is not possible with current implementation. It would require some logic in the operator, to watch ScaledObjects/ScaledJobs and TriggerAuths and then map triggerauth usages and store them probably into triggerauth.Status. Then we will be able to print them here.

Fair enough, added #796 for later on.

@tomkerkhove tomkerkhove merged commit 6619132 into kedacore:v2 Apr 29, 2020
zroubalik added a commit to zroubalik/keda that referenced this pull request May 20, 2020
zroubalik added a commit to zroubalik/keda that referenced this pull request Jun 17, 2020
zroubalik added a commit to zroubalik/keda that referenced this pull request Jul 7, 2020
@zroubalik zroubalik deleted the crdta branch August 11, 2020 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants