[V2] bump k8s to 1.18 and remove knative.dev deps #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 4, 2020 16:16
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
ahmelsayed
approved these changes
May 4, 2020
zroubalik
added a commit
to zroubalik/keda
that referenced
this pull request
May 20, 2020
zroubalik
added a commit
to zroubalik/keda
that referenced
this pull request
Jun 17, 2020
zroubalik
added a commit
to zroubalik/keda
that referenced
this pull request
Jul 7, 2020
zroubalik
added a commit
that referenced
this pull request
Aug 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support #802 we need to bump k8s.io version to 1.18 first. k8s.io 1.18 has introduced some breaking changes mainly in client-go interface, some of our deps aren't yet rebuilded to support this, I have worked it out this way: