-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
secrets from HashiCorp Vault #890
Conversation
Signed-off-by: Nisan Itzhakov <nisan.mfy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind opening a PR for our docs as well please?
Signed-off-by: Nisan Itzhakov <nisan.mfy@gmail.com>
PR to keda docs kedacore/keda-docs#199 |
@nisan270390 do you think you could add some tests to cover this scenario? |
@zroubalik All the logic around HashiCorpVault Handler is in the initializing of the vault client, I don't see a way to write tests that will test this topic well |
Secrets []VaultSecret `json:"secrets"` | ||
|
||
// +optional | ||
Credential Credential `json:"credetial"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there is a misspelling here that carries through in a couple other spots
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks a lot, updated :)
Signed-off-by: Nisan Itzhakov <nisan.mfy@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Added support for authentication with secrets from HashiCorp Vault by expanding the
TriggerAuthentication
resource with vault property which contains the authentication settings.Vault property allows next options:
address
- Vault address (format -<scheme>://<host>:<port>
)authentication
- authentication method (currently supported: token and kubernetes)role
andmount
credetial
- defines the Hashicorp Vault credentials depending on the authentication methodsecrets
- list that defines the mapping between the path of the secret and the key in Vault to the parameterfor example:
Fixes #
#673