[v2] temporary fix to be able to deploy ScaledJob on k8s 1.18 #926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
zroubalik
changed the title
tomkerkhove
approved these changes
Jul 9, 2020
zroubalik
added a commit
that referenced
this pull request
Aug 6, 2020
Signed-off-by: Zbynek Roubalik <zroubali@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zbynek Roubalik zroubali@redhat.com
We need to manually modify generated ScaledJob CRD, to be able to deploy it on k8s v 1.18.
There were validation improvements brought in k8s 1.18 and operator-sdk is not able to generate the CRD correctly.
Issue details: #927
This should help with e2e tests failures on v2 branch