Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v2] Unique MetricName for each Trigger in ScaledObject #966

Merged
merged 3 commits into from
Aug 5, 2020
Merged

[v2] Unique MetricName for each Trigger in ScaledObject #966

merged 3 commits into from
Aug 5, 2020

Conversation

samuelmacko
Copy link
Contributor

@samuelmacko samuelmacko commented Aug 3, 2020 •
edited by zroubalik
Loading

Added unique name for every scaler. Multiple metrics for one ScaledObject can be used.

Checklist

Fixes #733

@samuelmacko
metric name and unit tests
fe68806 
Signed-off-by: samuelmacko <samuel.macko.sm@gmail.com>
@samuelmacko
metricName and unit test for cron
1a16da9 
Signed-off-by: samuelmacko <samuel.macko.sm@gmail.com>
@zroubalik zroubalik changed the title Unique name [v2] Unique name Aug 3, 2020
@zroubalik zroubalik changed the title [v2] Unique name [v2] Unique MetricName for each Trigger in ScaledObject Aug 3, 2020
zroubalik
zroubalik approved these changes Aug 3, 2020
View reviewed changes
Copy link
Member

@zroubalik zroubalik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just very minor nits

pkg/scalers/aws_kinesis_stream_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/cron_scaler.go Outdated Show resolved Hide resolved
pkg/scalers/cron_scaler.go Outdated Show resolved Hide resolved
ahmelsayed
ahmelsayed approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@ahmelsayed ahmelsayed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMT

@samuelmacko
unique name - small fixes
3d5382a 
Signed-off-by: samuelmacko <samuel.macko.sm@gmail.com>
@zroubalik zroubalik merged commit a9f70e3 into kedacore:v2 Aug 5, 2020
This was referenced Aug 5, 2020
Closed
Closed
zroubalik pushed a commit that referenced this pull request Aug 6, 2020
@samuelmacko
[v2] Unique MetricName for each Trigger in ScaledObject (#966)
ddeedbf 
Signed-off-by: samuelmacko <samuel.macko.sm@gmail.com>
@ahmelsayed ahmelsayed mentioned this pull request Aug 11, 2020
Merged
3 tasks
@samuelmacko samuelmacko deleted the unique-name branch August 13, 2020 07:39
SpiritZhou pushed a commit to SpiritZhou/keda that referenced this pull request Jul 18, 2023
chore: add cloudID and apiKey to elasticsearch scaler (kedacore#966)
3e36b9a 
Fixes kedacore#3785
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zroubalik zroubalik zroubalik approved these changes

@ahmelsayed ahmelsayed ahmelsayed approved these changes

Assignees

@ahmelsayed ahmelsayed

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuelmacko @ahmelsayed @zroubalik