[v2] BugFix and Updates for Artemis ActiveMQ scaler #986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix allows to use a scaler definition without kubernetes secret, passing username and password in scaler metadata according to documentation for scaler Signed-off-by: Sergiy Poplavskyi <spopla@microsoft.com>
This fix address an "invalid argument" exception, that throwing any time, when this line executed. Signed-off-by: Sergiy Poplavskyi <spopla@microsoft.com>
…e able to finetune ActiveMQ endpoint In different versions (or configurations) ActiveMQ REST andpoint can be different, than hardcoded in this scaler. To be able to finetune it, I have introduced an optional parameter to change this template. Signed-off-by: Sergiy Poplavskyi <spopla@microsoft.com>
For some reason, ActiveMQ scaler wasn't added to v2. This commit will fix it. Signed-off-by: Sergiy Poplavskyi <spopla@microsoft.com>
|
@spoplavskiy good catch, thanks! Could you please open another PR on kedacore/keda-docs repo and add documentation for the feature you have implemented? The scaler docs for v2 are in this file: |
zroubalik
changed the title
@zroubalik , thanks for advice. |
3 tasks
preflightsiren
pushed a commit
to preflightsiren/keda
that referenced
this pull request
Nov 7, 2021
…#986 (kedacore#222) - Changed "scaleTargetRef" definition example according to V2 - Added metadata paramer "restApiTemplate", that introduced in PR: kedacore#986 Signed-off-by: Sergiy Poplavskyi <spopla@microsoft.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has fixes for a bugs I faced with during deployment and setting up a scaler.
Also, I want to introduce additional metadata parameter "restApiTemplate" that address the following problem:
As of now, REST API url to get a queue size is hardcoded and looks like this:
"http://<<managementEndpoint>>/console/jolokia/read/org.apache.activemq.artemis:broker=\"<<brokerName>>\",component=addresses,address=\"<<brokerAddress>>\",subcomponent=queues,routing-type=\"anycast\",queue=\"<<queueName>>\"/MessageCount"But there can be a cases, when a template is different. As an example, my endpoint looks like this:
"http://<<managementEndpoint>>/api/jolokia/read/org.apache.activemq:type=Broker,brokerName=<<brokerName>>,destinationType=Queue,destinationName=<<queueName>>/QueueSize"There is other examples of different endpoints for same api:
https://gist.github.com/yashpatil/de7437522bfccfeee4cb
https://activemq.apache.org/rest
To make this scaler more universal, "restApiTemplate" can be used to change a default REST endpoint.
Example value:
"http://<<managementEndpoint>>/api/jolokia/read/org.apache.activemq:type=Broker,brokerName=<<brokerName>>,destinationType=Queue,destinationName=<<queueName>>/QueueSize"<<managementEndpoint>>, <<brokerName>> and <<queueName>>will be automatically replaced by values from metadata in a runtime.This parameter doesn't break existing logic: if "restApiTemplate" is not specified, a default one will be used, which is the same, as it was before.
Checklist
Fixes #
Feature #
Docks #222
Signed-off-by: Sergiy Poplavskyi spopla@microsoft.com