Merge tag 'v4.1.6' into foresdon-v4.1.6 #59
kedamaDQAnnotations
10 errors and 10 warnings
|
lint:
app/controllers/admin/webhooks_controller.rb#L32
[Correctable] Rails/ActionOrder: Action show should appear before create.
|
|
lint:
app/controllers/api/v1/conversations_controller.rb#L14
[Correctable] Layout/LineLength: Line is too long. [188/140] (https://rubystyle.guide#max-line-length)
|
|
lint:
app/controllers/api/v1/statuses/histories_controller.rb#L16
[Correctable] Layout/LineLength: Line is too long. [148/140] (https://rubystyle.guide#max-line-length)
|
|
lint:
app/controllers/api/v1/statuses/reblogs_controller.rb#L35
[Correctable] Layout/LineLength: Line is too long. [178/140] (https://rubystyle.guide#max-line-length)
|
|
lint:
app/controllers/auth/registrations_controller.rb#L31
[Correctable] Rails/ActionOrder: Action update should appear before destroy.
|
|
lint:
app/controllers/auth/registrations_controller.rb#L60
[Correctable] Layout/LineLength: Line is too long. [210/140] (https://rubystyle.guide#max-line-length)
|
|
lint:
app/controllers/auth/registrations_controller.rb#L99
[Correctable] Rails/WhereExists: Prefer exists?(['ip >>= ?', request.remote_ip.to_s]) over where('ip >>= ?', request.remote_ip.to_s).exists?.
|
|
lint:
app/controllers/media_controller.rb#L35
[Correctable] Rails/FindById: Use find(id) instead of find_by!(id: id). (https://rails.rubystyle.guide/#find)
|
|
lint:
app/controllers/settings/two_factor_authentication/webauthn_credentials_controller.rb#L13
[Correctable] Rails/ActionOrder: Action index should appear before new.
|
|
lint:
app/controllers/statuses_controller.rb#L32
[Correctable] Layout/LineLength: Line is too long. [154/140] (https://rubystyle.guide#max-line-length)
|
|
lint:
app/lib/admin/system_check/media_privacy_check.rb#L81
[Correctable] Lint/RedundantCopDisableDirective: Unnecessary disabling of Rails/SkipsModelValidations.
|
|
lint:
app/validators/vote_validator.rb#L11
Lint/DuplicateBranch: Duplicate branch body detected.
|
|
lint:
lib/sanitize_ext/sanitize_config.rb#L73
[Correctable] Lint/OrAssignmentToConstant: Avoid using or-assignment with constants.
|
|
lint:
lib/sanitize_ext/sanitize_config.rb#L97
[Correctable] Lint/OrAssignmentToConstant: Avoid using or-assignment with constants.
|
|
lint:
spec/controllers/api/v2/admin/accounts_controller_spec.rb#L68
[Correctable] Lint/ParenthesesAsGroupedExpression: (expected_results.map { |symbol| send(symbol).id }) interpreted as grouped expression. (https://rubystyle.guide#parens-no-spaces)
|
|
lint:
spec/controllers/settings/two_factor_authentication/webauthn_credentials_controller_spec.rb#L137
Lint/AmbiguousBlockAssociation: Parenthesize the param change { user.webauthn_id } to make sure that the block will be associated with the change method call. (https://rubystyle.guide#syntax)
|
|
lint:
spec/controllers/settings/two_factor_authentication/webauthn_credentials_controller_spec.rb#L239
Lint/AmbiguousBlockAssociation: Parenthesize the param change { user.webauthn_id } to make sure that the block will be associated with the change method call. (https://rubystyle.guide#syntax)
|
|
lint:
spec/services/resolve_url_service_spec.rb#L11
Lint/UselessAssignment: Useless assignment to variable - known_account. (https://rubystyle.guide#underscore-unused-vars)
|
|
lint:
spec/workers/scheduler/accounts_statuses_cleanup_scheduler_spec.rb#L108
Lint/AmbiguousBlockAssociation: Parenthesize the param change { account2.statuses.count } to make sure that the block will be associated with the change method call. (https://rubystyle.guide#syntax)
|
|
lint:
spec/workers/scheduler/accounts_statuses_cleanup_scheduler_spec.rb#L112
Lint/AmbiguousBlockAssociation: Parenthesize the param change { account4.statuses.count } to make sure that the block will be associated with the change method call. (https://rubystyle.guide#syntax)
|