Merge tag 'v4.2.1' into foresdon-v4.2.1 #69
kedamaDQAnnotations
10 errors
|
lint:
app/controllers/directories_controller.rb#L26
[Correctable] Style/RedundantReturn: Redundant return detected. (https://rubystyle.guide#no-explicit-return)
|
|
lint:
app/helpers/accounts_helper.rb#L52
[Correctable] Rails/ContentTag: Use tag.use instead of tag(:use). (https://github.com/rubocop/rubocop-rails/issues/260, https://github.com/rails/rails/issues/25195, https://api.rubyonrails.org/classes/ActionView/Helpers/TagHelper.html#method-i-content_tag)
|
|
lint:
app/helpers/accounts_helper.rb#L56
[Correctable] Rails/ContentTag: Use tag.use instead of tag(:use). (https://github.com/rubocop/rubocop-rails/issues/260, https://github.com/rails/rails/issues/25195, https://api.rubyonrails.org/classes/ActionView/Helpers/TagHelper.html#method-i-content_tag)
|
|
lint:
app/models/account_tag_stat.rb#L2
[Correctable] Layout/EmptyLineAfterMagicComment: Add an empty line after magic comments. (https://rubystyle.guide#separate-magic-comments-from-code)
|
|
lint:
app/models/tag.rb#L183
[Correctable] Layout/EmptyLineAfterGuardClause: Add empty line after guard clause.
|
|
lint:
config/routes.rb#L138
[Correctable] Layout/CommentIndentation: Incorrect indentation detected (column 0 instead of 2).
|
|
lint:
db/migrate/20190529143559_preserve_old_layout_for_existing_users.rb#L11
[Correctable] Rails/PluralizationGrammar: Prefer 2.years.
|
|
lint:
spec/models/account_tag_stat_spec.rb#L5
[Correctable] RSpec/Rails/InferredSpecType: Remove redundant spec type. (https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/Rails/InferredSpecType)
|
|
lint:
spec/models/account_tag_stat_spec.rb#L12
RSpec/MessageSpies: Prefer have_received for setting message expectations. Setup account_tag_stat as a spy using allow or instance_spy. (https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/MessageSpies)
|
|
lint:
spec/models/account_tag_stat_spec.rb#L19
[Correctable] RSpec/ExpectChange: Prefer change(account_tag_stat, :accounts_count). (https://www.rubydoc.info/gems/rubocop-rspec/RuboCop/Cop/RSpec/ExpectChange)
|