This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
New Kedge structure = new documentation #569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kadel
reviewed
Jan 18, 2018
docs/file-reference.md
Outdated
| | name | string | yes | The name of the app or microservice this particular file defines. | | ||
| | appversion | string | no | The version of the app or microservice this particular file defines. | | ||
| | labels | object | no | Map of string keys and values that can be used to organize and categorize (scope and select) objects. May match selectors of replication controllers and services. | | ||
| | deployments | array of [deploymentObject](#deploymentObject) | no | [deploymentObject](#deploymentObject) | |
There was a problem hiding this comment.
those links are not working, it should be lowercase
[deploymentObject](#deploymentobject)
The same for jobs and dpeloymentconfigs
There was a problem hiding this comment.
Yeah... I always forget that 👎 updated!
This reorganizes and rewrites many parts of the file reference to reflect the new format of Kedge (separate keys for each controller). Tables are now correctly formatted as well as some minor reoganizational / structural changes to the documentation.
cdrage
force-pushed
the
docs-for-new-structure
branch
from
f268c8c
to
7672f22
Compare
|
@kadel I seem to always forget that links don't work unless it's lowercase in markdown. Changes pushed. |
kadel
approved these changes
Jan 19, 2018
|
👍 nice work @cdrage |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reorganizes and rewrites many parts of the file reference to
reflect the new format of Kedge (separate keys for each controller).
Tables are now correctly formatted as well as some minor reoganizational
/ structural changes to the documentation.