Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename extra import with non capitalized "S" to "Dataset" #403

Closed
Galileo-Galilei opened this issue Oct 22, 2023 · 2 comments
Closed

Rename extra import with non capitalized "S" to "Dataset" #403

Galileo-Galilei opened this issue Oct 22, 2023 · 2 comments

Comments

@Galileo-Galilei
Copy link
Member

Description

All Datasets have been rename without a capital "S", e.g. CSVDataSet->CSVDataset:

class CSVDataset(AbstractVersionedDataset[pd.DataFrame, pd.DataFrame]):

but most (not all) of the extra imports still use the capitalized version:

"pandas.CSVDataSet": [PANDAS],

Context

We should aim for consistency, but maybe this will be done once the setup.py will be refactored to a pyproject.toml?

@Galileo-Galilei Galileo-Galilei changed the title Ranem extra import with non capitalized "S" to Dataset Rename extra import with non capitalized "S" to "Dataset" Oct 22, 2023
@astrojuanlu
Copy link
Member

We'll need to figure out alternative names anyway #313

@Galileo-Galilei
Copy link
Member Author

Did not see that. I close the issue, sorry for the noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants